Skip to content

Commit fbf772e

Browse files
committed
Update kubernetes.use_secret_as_volume to accept secret name as a parameter
Signed-off-by: ddalvi <ddalvi@redhat.com>
1 parent 10aaf43 commit fbf772e

File tree

1 file changed

+6
-3
lines changed
  • kubernetes_platform/python/kfp/kubernetes

1 file changed

+6
-3
lines changed

kubernetes_platform/python/kfp/kubernetes/secret.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
from kfp.dsl import PipelineTask
1919
from kfp.kubernetes import common
2020
from kfp.kubernetes import kubernetes_executor_config_pb2 as pb
21-
21+
from typing import Union
22+
from kfp.dsl.pipeline_channel import PipelineParameterChannel
2223

2324
def use_secret_as_env(
2425
task: PipelineTask,
@@ -59,7 +60,7 @@ def use_secret_as_env(
5960

6061
def use_secret_as_volume(
6162
task: PipelineTask,
62-
secret_name: str,
63+
secret_name: Union[str, PipelineParameterChannel],
6364
mount_path: str,
6465
optional: bool = False,
6566
) -> PipelineTask:
@@ -75,7 +76,9 @@ def use_secret_as_volume(
7576
Returns:
7677
Task object with updated secret configuration.
7778
"""
78-
79+
# Extract the actual string value if secret_name is a PipelineParameterChannel
80+
if isinstance(secret_name, PipelineParameterChannel):
81+
secret_name = secret_name.name
7982
msg = common.get_existing_kubernetes_config_as_message(task)
8083

8184
secret_as_vol = pb.SecretAsVolume(

0 commit comments

Comments
 (0)