-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[feature] Reintroduce add_resource_limit to kfp v2 SDK or another resource requests/limits mechanism #10996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/remove-lifecycle stale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/remove-lifecycle stale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
/reopen |
@dariuszg-gc: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle stale |
Feature Area
/area sdk
What feature would you like to see?
Reintroduction of
add_resource_limit
andadd_resource_request
from v1 to v2 SDK.pipelines/sdk/python/kfp/deprecated/dsl/_container_op.py
Line 268 in 38ef986
pipelines/sdk/python/kfp/deprecated/dsl/_container_op.py
Line 281 in 38ef986
OR another mechanism to allow flexible specification of multiple resource requests/limits
What is the use case or pain point?
Currently the only mechanism to achieve setting resource limit is available via the
set_accelerator_type
andset_accelerator_limit
methods (with intention to use it for GPU/TPU devices), however it allows to specify them only for a singular resource.There are several use cases that require usage of multiple DevicePlugin/DRA managed devices (e.g GPU + RDMA RNIC), thus the need for a mechanism that allows adding multiple resource limits/requests to the pod spec.
Is there a workaround currently?
None (v2) or use of deprecated version.
Love this idea? Give it a 👍.
The text was updated successfully, but these errors were encountered: