Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): create a test to check whether requirements.txt was generated with pip-compile #11512

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

mahdikhashan
Copy link

@mahdikhashan mahdikhashan commented Jan 14, 2025

Description of your changes:
resolves #11495

Checklist:

Copy link

Hi @mahdikhashan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mahdikhashan mahdikhashan changed the title chore: chore(tests): create a test to check whether requirements.txt was generated with pip-compile Jan 14, 2025
@mahdikhashan mahdikhashan changed the title chore(tests): create a test to check whether requirements.txt was generated with pip-compile [WIP] chore(tests): create a test to check whether requirements.txt was generated with pip-compile Jan 14, 2025
@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Jan 14, 2025
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
@mahdikhashan mahdikhashan force-pushed the test-to-check-whether-requirements-txt-was-generated-with-pip-compile branch from 02fc4c7 to d669f38 Compare January 14, 2025 15:54
@mahdikhashan mahdikhashan changed the title [WIP] chore(tests): create a test to check whether requirements.txt was generated with pip-compile chore(tests): create a test to check whether requirements.txt was generated with pip-compile Jan 14, 2025
@mahdikhashan mahdikhashan marked this pull request as ready for review January 14, 2025 15:54
@google-oss-prow google-oss-prow bot requested a review from HumairAK January 14, 2025 15:55
@mahdikhashan
Copy link
Author

mahdikhashan commented Jan 14, 2025

@hbelmiro i kindly request for your review on this pr. thanks

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

.github/workflows/requirements-test.yaml Outdated Show resolved Hide resolved
.github/workflows/requirements-test.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this file to requirements-txt-automatically-generated.yaml?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@hbelmiro
Copy link
Contributor

@mahdikhashan can you please link this PR to the issue?

Screenshot 2025-01-15 at 09 53 29

Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Signed-off-by: Mahdi Khashan <58775404+mahdikhashan@users.noreply.github.com>
@mahdikhashan
Copy link
Author

@mahdikhashan can you please link this PR to the issue?

Screenshot 2025-01-15 at 09 53 29

done

mahdikhashan and others added 3 commits January 15, 2025 13:56
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Signed-off-by: Mahdi Khashan <58775404+mahdikhashan@users.noreply.github.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
@mahdikhashan mahdikhashan requested a review from hbelmiro January 15, 2025 13:01
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Jan 16, 2025
@mahdikhashan
Copy link
Author

mahdikhashan commented Jan 16, 2025

I'm facing the same issue: google/ml-metadata#191 (comment), @hbelmiro

since i'm on mac with m cpu, i could't use the update_requirements.sh script - the docker image was only for amd64. any tips on overcoming? shall i add a build script for this package? (to build it with cpython in a docker file?)

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun, hbelmiro for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mahdikhashan
Copy link
Author

@hbelmiro would you please run the test once more? in addition, on mac m1, i couldnt compile the requirements for ml-metadata and visualisation. i appreciate any hints.

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@hbelmiro
Copy link
Contributor

on mac m1, i couldnt compile the requirements for ml-metadata and visualisation. i appreciate any hints.

@mahdikhashan what do you see?

@mahdikhashan
Copy link
Author

on mac m1, i couldnt compile the requirements for ml-metadata and visualisation. i appreciate any hints.

@mahdikhashan what do you see?

for metadata, the same issue as here: google/ml-metadata#191 (comment)

for visulization, the building of packages (c language) are failing.

@hbelmiro
Copy link
Contributor

on mac m1, i couldnt compile the requirements for ml-metadata and visualisation. i appreciate any hints.

@mahdikhashan what do you see?

for metadata, the same issue as here: google/ml-metadata#191 (comment)

for visulization, the building of packages (c language) are failing.

@mahdikhashan have you taken a look at this comment?
I'd say to not invest much time on this. If you can't make it work, just copy the result of the workflow you're creating.

@mahdikhashan
Copy link
Author

on mac m1, i couldnt compile the requirements for ml-metadata and visualisation. i appreciate any hints.

@mahdikhashan what do you see?

for metadata, the same issue as here: google/ml-metadata#191 (comment)

for visulization, the building of packages (c language) are failing.

@mahdikhashan have you taken a look at this comment?
I'd say to not invest much time on this. If you can't make it work, just copy the result of the workflow you're creating.

ok, I'll try to copy the workflow result. (I saw the mentioned comment but didn't try it)

@hbelmiro
Copy link
Contributor

on mac m1, i couldnt compile the requirements for ml-metadata and visualisation. i appreciate any hints.

@mahdikhashan what do you see?

for metadata, the same issue as here: google/ml-metadata#191 (comment)
for visulization, the building of packages (c language) are failing.

@mahdikhashan have you taken a look at this comment?
I'd say to not invest much time on this. If you can't make it work, just copy the result of the workflow you're creating.

ok, I'll try to copy the workflow result. (I saw the mentioned comment but didn't try it)

@mahdikhashan don't do that for all files though. If you face new issues, ne need to assess them.

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
@mahdikhashan mahdikhashan force-pushed the test-to-check-whether-requirements-txt-was-generated-with-pip-compile branch from 4d142c4 to 6fbfc08 Compare January 16, 2025 16:15
@mahdikhashan
Copy link
Author

on mac m1, i couldnt compile the requirements for ml-metadata and visualisation. i appreciate any hints.

@mahdikhashan what do you see?

for metadata, the same issue as here: google/ml-metadata#191 (comment)
for visulization, the building of packages (c language) are failing.

@mahdikhashan have you taken a look at this comment?
I'd say to not invest much time on this. If you can't make it work, just copy the result of the workflow you're creating.

ok, I'll try to copy the workflow result. (I saw the mentioned comment but didn't try it)

@mahdikhashan don't do that for all files though. If you face new issues, ne need to assess them.

ok, i updated the visualization requirements. would you please trigger the tests again.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

bokeh==1.2.0
# via -r -
# via -r ./backend/src/apiserver/visualization/requirements.in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't leave the full path because developers will run pip-compile from the directory where the requirements.in file is.
I think we can achieve the same behaviour in the CI by using working-directory.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i'll fix it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
@mahdikhashan mahdikhashan requested a review from hbelmiro January 17, 2025 17:34
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(tests): Create a test to check whether requirements.txt was generated with pip-compile
2 participants