-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): create a test to check whether requirements.txt
was generated with pip-compile
#11512
base: master
Are you sure you want to change the base?
Conversation
Hi @mahdikhashan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
requirements.txt
was generated with pip-compile
requirements.txt
was generated with pip-compile
requirements.txt
was generated with pip-compile
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
02fc4c7
to
d669f38
Compare
requirements.txt
was generated with pip-compile
requirements.txt
was generated with pip-compile
@hbelmiro i kindly request for your review on this pr. thanks |
/ok-to-test |
Approvals successfully granted for pending runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this file to requirements-txt-automatically-generated.yaml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
@mahdikhashan can you please link this PR to the issue? |
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Mahdi Khashan <58775404+mahdikhashan@users.noreply.github.com>
done |
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Mahdi Khashan <58775404+mahdikhashan@users.noreply.github.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
|
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hbelmiro would you please run the test once more? in addition, on mac m1, i couldnt compile the requirements for ml-metadata and visualisation. i appreciate any hints. |
/ok-to-test |
Approvals successfully granted for pending runs. |
@mahdikhashan what do you see? |
for metadata, the same issue as here: google/ml-metadata#191 (comment) for visulization, the building of packages (c language) are failing. |
@mahdikhashan have you taken a look at this comment? |
ok, I'll try to copy the workflow result. (I saw the mentioned comment but didn't try it) |
@mahdikhashan don't do that for all files though. If you face new issues, ne need to assess them. |
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
4d142c4
to
6fbfc08
Compare
ok, i updated the visualization requirements. would you please trigger the tests again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
bokeh==1.2.0 | ||
# via -r - | ||
# via -r ./backend/src/apiserver/visualization/requirements.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't leave the full path because developers will run pip-compile
from the directory where the requirements.in
file is.
I think we can achieve the same behaviour in the CI by using working-directory
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i'll fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/ok-to-test |
Approvals successfully granted for pending runs. |
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
/ok-to-test |
Approvals successfully granted for pending runs. |
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
/ok-to-test |
Approvals successfully granted for pending runs. |
Description of your changes:
resolves #11495
Checklist: