Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[frontend]: implement artifact-repositories configmap support #11354

Merged
merged 2 commits into from
Nov 20, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Improve error handling
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
droctothorpe committed Nov 19, 2024
commit efabeb5a467c06bcea4de54f9e488898ebc4bc53
8 changes: 3 additions & 5 deletions frontend/server/workflow-helper.ts
Original file line number Diff line number Diff line change
@@ -171,13 +171,11 @@ export async function getKeyFormatFromArtifactRepositories(
namespace: string,
): Promise<string | undefined> {
try {
const [configMap] = await getConfigMap('artifact-repositories', namespace);
const [configMap, k8sError] = await getConfigMap('artifact-repositories', namespace);
if (configMap === undefined) {
// If there is no artifact-repositories configmap, return undefined. The
// caller will just use keyFormat as specified in configs.ts.
return undefined;
throw k8sError;
}
let artifactRepositories = configMap?.data['artifact-repositories'];
const artifactRepositories = configMap?.data['artifact-repositories'];
const artifactRepositoriesValue = JsYaml.safeLoad(
artifactRepositories,
) as PartialArtifactRepositoriesValue;
1 change: 1 addition & 0 deletions manifests/kustomize/base/pipeline/ml-pipeline-ui-role.yaml
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@ rules:
- ""
resources:
- secrets
- configmaps
verbs:
- get
- list