feat: add support for customizing connect service #2709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
nabuskey
reviewed
Nov 4, 2025
|
|
||
| // Create the client rest config. Use kubeConfig if given, otherwise assume in-cluster. | ||
| cfg, err := ctrl.GetConfig() | ||
| cfg.WarningHandler = rest.NoWarnings{} |
Member
Author
There was a problem hiding this comment.
Warnings will arise if we add corev1.Service as a field. The reason is, fileds like metadata.creationTimestamp exist in Go struct but did not exist in CRD.
Similar issues: kubernetes-sigs/controller-runtime#2956.
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Proposed changes:
Add support for customizing Spark connect server service.
sparkconnect.spec.server.serviceand it will be used as a template if specified.Change Category
Rationale
Checklist
Additional Notes