Display the predefined category tags for vSphere cluster tags #7721
Conversation
kubermatic-bot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
size/M
KhizerRehan
left a comment
KhizerRehan
left a comment
There was a problem hiding this comment.
Feedback Added (PTAL)
|
|
||
| <mat-form-field fxFlex *ngIf="networks.length > 1"> | ||
| <mat-form-field fxFlex | ||
| *ngIf="networks.length > 1"> |
There was a problem hiding this comment.
This syntax will be soon deprecated. We can use updated control flow syntax
| this._clusterSpecService.cluster.spec.cloud.vsphere.folder = folder; | ||
| } | ||
|
|
||
| onLoadingTags(): void {} |
| [kmPatternError]="tagValuesPatternError" | ||
| [kmRequired]="!!form.get(Controls.TagCategory).value" | ||
| fxFlex /> | ||
| <km-chip-autocomplete [formControlName]="Controls.Tags" |
There was a problem hiding this comment.
2 Questions:
I think this is the first time in codebase we are using this custom element i can't find any other usages in other parts of codebase. Just Curios (seem little outdated) I guess
There was a problem hiding this comment.
Q2:
Compare to dev -> km-chip-list shows validations as we are passing
[kmPattern]="tagValuesPattern"
[kmPatternError]="tagValuesPatternError"
therefor i can see in dev validations works for cluster tags
With km-chip-autocomplete (Validations I guess missing) in component itself. Which IMO, we need to restrict user to provide any invalid tags.
ahmadhamzh
force-pushed
the
7395-dropdown-menue-for-cluster-tag
branch
from
25cfb99 to
7f4e262
Compare
3 participants
What this PR does / why we need it:
Show the list of predefined category tags for vSphere cluster tags, and also keep the option to add other tags manually.
Which issue(s) this PR fixes:
Fixes #7395
What type of PR is this?
/kind feature
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: