Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health should be configurable in the helm chart #1411

Open
nwsparks opened this issue Jul 16, 2024 · 4 comments
Open

health should be configurable in the helm chart #1411

nwsparks opened this issue Jul 16, 2024 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@nwsparks
Copy link

the efs-plugin is frequently failing it's liveness probe on startup. I believe the current configuration in the helm chart is set to check too frequently (period: 2)

it would be simple to change this to allow configuration via helm values. to keep it in line with the existing healthPort I would propose adding the following to the controller and node sections.

  healthInitialDelaySeconds: 10
  healthTimeoutSeconds: 3
  healthPeriodSeconds: 10
  healthFailureThreshold: 5

I can raise a PR.

@seanzatzdev-amazon
Copy link
Contributor

Can you provide logs & raise that PR?

@nwsparks
Copy link
Author

nwsparks commented Aug 1, 2024

sorry for the delay. I can.

logs generally look like this. a bit tough to determine exactly what's happening here, my initial thought was looking at raising the initialdelay which brought me here.

image

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2024
@nwsparks
Copy link
Author

pr is open #1428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants