-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
progress indicator #223
Comments
(Or even no spinner but just periodically print a count of completed tests / total tests with the current timestamp) We used to have an experience like this when manually running the conformance e2e tests against tools / products / ... for submitting them to https://github.com/cncf/k8s-conformance, this feels like a regression between the assorted tooling. |
I see that currently we don't have the pod configured to print anything: $ kubectl logs -n=conformance e2e-conformance-test
Defaulted container "conformance-container" out of: conformance-container, output-container
2024/12/16 22:16:29 Running command:
Command env: []
Run from directory:
Executable path: /usr/local/bin/ginkgo
Args (comma-delimited): /usr/local/bin/ginkgo,--focus=\[Conformance\],--skip=,--no-color=true,--timeout=24h,/usr/local/bin/e2e.test,--,--disable-log-dump,--repo-root=/kubernetes,--provider=skeleton,--report-dir=/tmp/results,--kubeconfig=
2024/12/16 22:16:29 Now listening for interrupts
I1216 22:16:30.364816 33 e2e.go:109] Starting e2e run "5e702b17-ac49-47b3-b5ac-fdede8df27dd" on Ginkgo node 1
Running Suite: Kubernetes e2e suite - /usr/local/bin
====================================================
Random Seed: 1734387389 - will randomize all specs
Will run 411 of 6622 specs But we can fix that. |
We're actually already logging like this:
Just only in So we can get the total from the |
It would be nice to have some idea how far along the running tests has gotten, given the multi-hour duration of conformance tests.
/kind feature
/sig testing
Right now there's nothing logged until the test completes, and the spinner doesn't inspire confidence over multiple hours that we're actually getting anywhere.
cc @pohly for thoughts on how best to integrate with the ginkgo reporter.
My rough thinking: We should be able to have ginkgo at least print a "." per test and then count those and include them alongside the spinner, plus parse the "will run x out of y specs"
Something like:
Could instead be like:
The text was updated successfully, but these errors were encountered: