Skip to content

Commit 72dd179

Browse files
committed
Add missing error handling for --load-restrictor completion
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
1 parent 7228a28 commit 72dd179

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

kustomize/commands/build/build.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,18 @@ func NewCmdBuild(
100100
return err
101101
},
102102
}
103+
103104
AddFlagOutputPath(cmd.Flags())
104105
AddFunctionBasicsFlags(cmd.Flags())
105106
AddFlagLoadRestrictor(cmd.Flags())
106-
AddFlagLoadRestrictorCompletion(cmd)
107107
AddFlagEnablePlugins(cmd.Flags())
108108
AddFlagReorderOutput(cmd.Flags())
109109
AddFlagEnableManagedbyLabel(cmd.Flags())
110110

111+
if err := AddFlagLoadRestrictorCompletion(cmd); err != nil {
112+
log.Fatalf("Error adding completion for flag '--load-restrictor': %v", err)
113+
}
114+
111115
msg := "Error marking flag '%s' as deprecated: %v"
112116
err := cmd.Flags().MarkDeprecated(flagReorderOutputName,
113117
"use the new 'sortOptions' field in kustomization.yaml instead.")

kustomize/commands/build/flagloadrestrictor.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ func AddFlagLoadRestrictor(set *pflag.FlagSet) {
2424
"relocatability of the kustomization.")
2525
}
2626

27-
func AddFlagLoadRestrictorCompletion(cmd *cobra.Command) {
28-
cmd.RegisterFlagCompletionFunc(flagLoadRestrictorName, func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
27+
func AddFlagLoadRestrictorCompletion(cmd *cobra.Command) error {
28+
return cmd.RegisterFlagCompletionFunc(flagLoadRestrictorName, func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
2929
return []string{
3030
types.LoadRestrictionsNone.String(),
3131
types.LoadRestrictionsRootOnly.String(),

0 commit comments

Comments
 (0)