Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive format changed #5396

Closed
VivaLaPanda opened this issue Oct 19, 2023 · 6 comments
Closed

Archive format changed #5396

VivaLaPanda opened this issue Oct 19, 2023 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@VivaLaPanda
Copy link

What happened?

Was it intentional for the archive format to change with the latest release? It broke out builds (because the output is now in output/kustomize instead of the root. We can adjust our builds if needed, but wanted to make sure this was intentional before doing so.

What did you expect to happen?

Archive unpacks to output/kustomize instead of kustomize

How can we reproduce it (as minimally and precisely as possible)?

Download the archive, open it up, look at the directory

Expected output

No response

Actual output

No response

Kustomize version

5.2.0

Operating system

Linux
@VivaLaPanda VivaLaPanda added the kind/bug Categorizes issue or PR as related to a bug. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@j-chao
Copy link

j-chao commented Oct 19, 2023

#5397 might fix this?

@gabrielcho
Copy link

Can confirm this change broke pipelines on my end when installing Kustomize through install_kustomize.sh
I get: cp: cannot stat './kustomize': No such file or directory as a result of this format change.

javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Set kustomize-version to 5.1.1 due to error
7b49e21 
There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

For now just add an optional variable so we can also control this at the organization or repository level. We can make this an action input as well.
@j-chao
Copy link

j-chao commented Oct 19, 2023 •
edited
Loading

@gabrielcho
FYI, you can mitigate this by explicitly passing a version for install_kustomize.sh:
ie: ./install_kustomize.sh 5.1.0

javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Set kustomize-version to 5.1.1 due to error
7737d8e 
There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

For now just add an optional variable so we can also control this at the organization or repository level. We can make this an action input as well.
javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Add kustomize-version input with 5.1.1 default
e408a9a 
There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

Initial approach didn't work with GHA variables so we'll use a new input but default its value for backwards compatibility.
javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Add kustomize-version input with 5.1.1 default
3435053 
There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

Initial approach didn't work with GHA variables so we'll use a new input but default its value for backwards compatibility.
javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Add kustomize-version input with 5.1.1 default
0915573 
There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

Initial approach didn't work with GHA variables so we'll use a new input but default its value for backwards compatibility.
@natasha41575
Copy link
Contributor

We have a fix in progress and will fix as soon as possible, in the meantime if you rely on the output format, it is advised to use the previous kustomize version.

@natasha41575 natasha41575 mentioned this issue Oct 19, 2023
Closed
javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Add kustomize-version input with 5.1.1 default
981be87 
There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

Initial approach didn't work with GHA variables so we'll use a new input but default its value for backwards compatibility.
@javierjulio javierjulio mentioned this issue Oct 19, 2023
Merged
javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Add kustomize-version input with working (5.1.1) default (#9)
126fcfa 
Add kustomize-version input with 5.1.1 default

There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

Initial approach didn't work with GHA variables so we'll use a new input but default its value for backwards compatibility.
javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Add kustomize-version input with 5.1.1 default
2f07c4f 
There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

Initial approach didn't work with GHA variables so we'll use a new input but default its value for backwards compatibility.
@javierjulio javierjulio mentioned this issue Oct 19, 2023
Merged
javierjulio added a commit to jackpocket/update-image-tag-action that referenced this issue Oct 19, 2023
@javierjulio
Add kustomize-version input with working (5.1.1) default (#10)
a96dfb6 
Add kustomize-version input with 5.1.1 default

There is an error with the archive format as part of the 5.2.0 release that is causing all our deployment builds to fail.

kubernetes-sigs/kustomize#5396

Initial approach didn't work with GHA variables so we'll use a new input but default its value for backwards compatibility.
@natasha41575
Copy link
Contributor

natasha41575 commented Oct 19, 2023 •
edited
Loading

Resolved now, I confirmed that install_kustomize.sh is working on the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@VivaLaPanda @gabrielcho @natasha41575 @j-chao @k8s-ci-robot