Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please hardcode version numbers instead of relying on ldflags #3016

Open
agowa opened this issue Aug 30, 2024 · 0 comments
Open

Please hardcode version numbers instead of relying on ldflags #3016

agowa opened this issue Aug 30, 2024 · 0 comments

Comments

@agowa
Copy link

agowa commented Aug 30, 2024

Hi,

please reconsider the reliance on ldflags for provide a simple way to indentify the deployed version of vsphere-csi.

// Version of the driver. This should be set via ldflags.

Currently a lot of deployments ship vsphere-csi-driver in a state that it just outputs a blank line. This makes it unnecessarily difficult to identify its version number.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant