-
Notifications
You must be signed in to change notification settings - Fork 189
Please hardcode version numbers instead of relying on ldflags #3016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten Issue still exists and I still see value in adding the version number as otherwise it won't be included at (and trying to identify the version without the version number, well, is just annoying) |
Hi,
please reconsider the reliance on ldflags for provide a simple way to indentify the deployed version of vsphere-csi.
vsphere-csi-driver/pkg/csi/service/identity.go
Line 26 in af2df0c
Currently a lot of deployments ship vsphere-csi-driver in a state that it just outputs a blank line. This makes it unnecessarily difficult to identify its version number.
The text was updated successfully, but these errors were encountered: