Skip to content

Commit 38124f2

Browse files
authored
Merge pull request #6507 from ctripcloud/check-empty-id-in-ali-NodeGroupForNode
fix empty ProviderID in ali NodeGroupForNode
2 parents aebba5a + e9d3d89 commit 38124f2

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

cluster-autoscaler/cloudprovider/alicloud/alicloud_cloud_provider.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,10 @@ func (ali *aliCloudProvider) NodeGroups() []cloudprovider.NodeGroup {
126126

127127
// NodeGroupForNode returns the node group for the given node.
128128
func (ali *aliCloudProvider) NodeGroupForNode(node *apiv1.Node) (cloudprovider.NodeGroup, error) {
129+
if len(node.Spec.ProviderID) == 0 {
130+
klog.Warningf("Node %v has no providerId", node.Name)
131+
return nil, nil
132+
}
129133
instanceId, err := ecsInstanceIdFromProviderId(node.Spec.ProviderID)
130134
if err != nil {
131135
klog.Errorf("failed to get instance Id from provider Id:%s,because of %s", node.Spec.ProviderID, err.Error())

0 commit comments

Comments
 (0)