New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing 404: Not Found message for missing providers #656

Closed

yaacov opened this issue Aug 2, 2023 · 2 comments

Assignees

Labels

bug ON QE

Milestone

Member

yaacov commented Aug 2, 2023 •

edited

Loading

Issue:
when getting a detail link for a missing provider we get an empty page:

forklift-console-plugin/packages/forklift-console-plugin/src/modules/Providers/views/details/ProviderDetailsPage.tsx

Lines 34 to 35 in 886798a

    
           default: 
        
             return <></>;

we should get a 404 page, for example:

yaacov added the bug label

yaacov added this to the 2.5.0 milestone

yaacov assigned rszwajko

Member Author

yaacov commented Aug 2, 2023

note:
this issue is about other cases falling into the not "happy" paths, for example loading.

yaacov added the ON QE label

Member Author

yaacov commented Aug 7, 2023

merged #666

yaacov closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment