Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] The popups of helm charts values.yaml needs improvement #851

Closed
cyxinda opened this issue Jun 29, 2023 · 1 comment · Fixed by #909
Closed

[Feature] The popups of helm charts values.yaml needs improvement #851

cyxinda opened this issue Jun 29, 2023 · 1 comment · Fixed by #909
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cyxinda
Copy link

cyxinda commented Jun 29, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
The popups of helm-charts values.yaml has very narrow width and needs improvement.

Describe the solution you'd like
the view for chrome:
222

the view for chrome:
firefox

Additional context
the velaux version is 1.9.1
the vela version is is 1.9.1
@chivalryq chivalryq added enhancement New feature or request good first issue Good for newcomers labels Jun 30, 2023
@am6737
Copy link
Contributor

am6737 commented Oct 1, 2024

/assign

am6737 added a commit to am6737/velaux that referenced this issue Oct 4, 2024
@am6737
feat: improve Helm charts values.yaml popup
29ae3e9 
- Added custom width (60vw) to Helm values.yaml dialog for better visibility.
- Enabled close modes: 'close' and 'mask' to improve user experience.

Closes kubevela#851

Signed-off-by: am6737 <1359816810@qq.com>
@am6737 am6737 mentioned this issue Oct 4, 2024
Closed
5 tasks
am6737 added a commit to am6737/velaux that referenced this issue Oct 4, 2024
@am6737
feat: improve Helm charts values.yaml popup
8b8024d 
- Added custom width (60vw) to Helm values.yaml dialog for better visibility.
- Enabled close modes: 'close' and 'mask' to improve user experience.

Closes kubevela#851

Signed-off-by: am6737 <1359816810@qq.com>
@am6737 am6737 mentioned this issue Oct 4, 2024
Merged
5 tasks
wonderflow pushed a commit that referenced this issue Oct 10, 2024
@am6737
feat: improve Helm charts values.yaml popup (#909)
d9b7ae1 
- Added custom width (60vw) to Helm values.yaml dialog for better visibility.
- Enabled close modes: 'close' and 'mask' to improve user experience.

Closes #851

Signed-off-by: am6737 <1359816810@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@cyxinda @chivalryq @am6737