Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix some typo errors #890

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

iambocai
Copy link
Contributor

Description of your changes

fix some typo errors.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

No.

Signed-off-by: 上郡 <shangjun.csb@alibaba-inc.com>
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2ab672c) 59.01% compared to head (9a4b4aa) 32.64%.

Files Patch % Lines
pkg/server/interfaces/api/application.go 0.00% 2 Missing ⚠️
pkg/server/interfaces/api/target.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #890       +/-   ##
===========================================
- Coverage   59.01%   32.64%   -26.38%     
===========================================
  Files         116       91       -25     
  Lines       19846    17940     -1906     
===========================================
- Hits        11713     5856     -5857     
- Misses       6696    11206     +4510     
+ Partials     1437      878      -559     
Flag Coverage Δ
apiserver-unittests 32.64% <0.00%> (+0.01%) ⬆️
server-e2e-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FogDong FogDong changed the title fix: fix some typo errors Fix: fix some typo errors Nov 24, 2023
@wonderflow wonderflow merged commit d5ea29f into kubevela:main Dec 5, 2023
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants