Fix: Username length in projects users to match users #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanasc
requested review from
barnettZQG,
chivalryq,
wangyikewxgm,
yangsoon and
FogDong
as code owners
oanasc
changed the title
Signed-off-by: Oana Schipor <oana.schipor@vortexa.com>
Signed-off-by: Oana Schipor <oana.schipor@vortexa.com>
|
The e2e tests checks for 1.21 are might need to be removed by a maintainer. Don't know if the matrix should include later versions of Kubernetes, i've just removed 1.21 because is not on the list of versions available for k3s anymore. |
FogDong
approved these changes
Jul 4, 2024
anoop2811
approved these changes
Jul 4, 2024
|
Thank you both @FogDong and @anoop2811. Would need some help with these statuses especially 1.21 to be removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
"Fixes SSO user default project not getting set #903": SSO user default project not getting set because the username vela_user.name doesn't have the same length as the username FK in vela_project_user
This means users logging in have no permissions whatsoever unless someone manually adds it.
The e2e tests were failing due to k3s version 1.21 not being available. I've removed the version from the matrix
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer