Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider image publishing script doesn't configure public access for new images #602

Open
enp0s3 opened this issue May 5, 2021 · 7 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@enp0s3
Copy link
Contributor

enp0s3 commented May 5, 2021

In Quay, if the image was created for the first time (in our case adding a new provider) it will be configured with private access.
We need to manually change it's access to public. We prefer an automated way to do so.

/cc @fgimenez @dhiller

@fgimenez
Copy link
Contributor

fgimenez commented May 5, 2021

Looks like the issue is related to the new quay account, kubevirtcibot, with the old one kubevirtbot, same publish scripts, all worked fine.

@dhiller
Copy link
Contributor

dhiller commented May 6, 2021

I've asked in the quay sig mailing list here: https://groups.google.com/g/quay-sig/c/zsnYAxv7gtQ

@dhiller
Copy link
Contributor

dhiller commented May 6, 2021

OK, looks like this is intentional behavior. As I see it we might have to add code to make the repository public via cli after the push.

@dhiller
Copy link
Contributor

dhiller commented May 6, 2021

As I see it we need to do a call to the api against post /api/v1/repository/{repository}/changevisibility

@dhiller
Copy link
Contributor

dhiller commented May 6, 2021

Also relevant: https://issues.redhat.com/browse/PROJQUAY-1224

@dhiller
Copy link
Contributor

dhiller commented May 7, 2021

Did a couple of experiments. As I see it, the work here outweighs the benefits. It's quite complicated to use the Quay API as besides the Bearer token a CSRF token is required, which I know no easy way of fetching from somewhere.

IMHO we have two options now:

  • wait for the implementation of the default for new repos on quay.io and remind ourselves to make the repo public every three months
  • add a repo pull test somewhere else w/o credentials, which should fail and remind us that we need to make the repo public

@dhiller
Copy link
Contributor

dhiller commented May 7, 2021

/lifecycle frozen

@kubevirt-bot kubevirt-bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants