Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-protection: remove required_status_check for dco on kubevirt/kubevirt.core #2927

Open
dhiller opened this issue Aug 10, 2023 · 6 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dhiller
Copy link
Contributor

dhiller commented Aug 10, 2023

Since kubevirt/kubevirt.core is having problems when doing their release with the dco check making the release fail, we tried to fix it with #2921

Contrary to our expectations branch-protector restores the dco check on the main branch.

We have two options:

  1. fix the branch-protector logic so that local context can override the global default
  2. move the default from org into each repository level
@dhiller
Copy link
Contributor Author

dhiller commented Aug 10, 2023

FYI @0xFelix

@0xFelix
Copy link
Member

0xFelix commented Aug 10, 2023

IMO 1. might be an option, but 2. sounds like unnecessary duplication and bloat of the manifest.

The kubevirt.core repository in general is an exemption, as it is using a lot of GitHub Actions instead of prow. So right now I would also be fine with removing the status check temporarily before a release, as we do not release that often and it's a process that needs to be started manually anyways.

@dhiller
Copy link
Contributor Author

dhiller commented Aug 10, 2023

IMO 1. might be an option, but 2. sounds like unnecessary duplication and bloat of the manifest.

The kubevirt.core repository in general is an exemption, as it is using a lot of GitHub Actions instead of prow. So right now I would also be fine with removing the status check temporarily before a release, as we do not release that often and it's a process that needs to be started manually anyways.

I agree that this is an exceptional case. Considering the maintainer state in test-infra I am not sure whether we would get a change for branch protector in anyway.

However, I am discontent with the situation since we need to remember what to do before a release of kubevirt.core ...

Since new repositories are urged to copy branch protection rules anyway, I'd be ok with the redundancy.

Anyhow I created this issue just as a reminder for us in case our older selves are wondering about it. Let's just keep it at that for now.

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2023
@dhiller
Copy link
Contributor Author

dhiller commented Nov 11, 2023

/remove-lifecycle stale
/lifecycle froze

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2023
@dhiller
Copy link
Contributor Author

dhiller commented Nov 11, 2023

/lifecycle frozen

@kubevirt-bot kubevirt-bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants