Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt|cdi, mirroring: run //robots/cmd/uploader:uploader as postsubmit for main and release branches #3097

Open
dhiller opened this issue Nov 30, 2023 · 17 comments
Labels
area/prow Issues and PRs concerning KubeVirt Prow, i.e. configuration, setup etc. good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dhiller
Copy link
Contributor

dhiller commented Nov 30, 2023

CentOS dependencies are sometimes removed from the mirror, which leads to build failures if the rpm mirroring has not uploaded them:

ERROR: /home/prow/go/src/github.com/kubevirt/kubevirt/rpm/BUILD.bazel:1619:8: //rpm:sandboxroot_x86_64 depends on @kernel-headers-0__5.14.0-375.el9.x86_64//rpm:rpm in repository @kernel-headers-0__5.14.0-375.el9.x86_64 which failed to fetch. no such package '@kernel-headers-0__5.14.0-375.el9.x86_64//rpm': java.io.IOException: Error downloading [http://mirror.stream.centos.org/9-stream/AppStream/x86_64/os/Packages/kernel-headers-5.14.0-375.el9.x86_64.rpm] to /tmp/cache/bazel/18316b1300bb8985bc913139d5cc6323/external/kernel-headers-0__5.14.0-375.el9.x86_64/rpm/downloaded: GET returned 404 Not Found

source

We should run the uploader prowjob1 for main and release branches as postsubmit to directly upload new dependencies to gcs so that this is backed up.

For this we need to split the one job into three and move each one in their own repository.

Concerns:

  • we might need to manually update the release branches as IIRC that branches: doesn't allow wildcards
  • PR's must be created against the correct branch, we need to use -T with PULL_BASE_REF

Footnotes

  1. https://github.com/kubevirt/project-infra/blob/f9b523d3ae40c184ef11dffe9299dbc0f6791122/github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-periodics.yaml#L214

@dhiller
Copy link
Contributor Author

dhiller commented Nov 30, 2023

See kubevirt/kubevirt#10591 and kubevirt/kubevirt#10812 as an example.

@dhiller
Copy link
Contributor Author

dhiller commented Nov 30, 2023

FYI @brianmcarey

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2024
@akalenyu
Copy link
Contributor

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 29, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Mar 22, 2024

/area prow

@kubevirt-bot kubevirt-bot added the area/prow Issues and PRs concerning KubeVirt Prow, i.e. configuration, setup etc. label Mar 22, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Mar 22, 2024

/good-first-issue

@kubevirt-bot
Copy link
Contributor

@dhiller:
This request has been marked as suitable for new contributors.

Guidelines

  • No Barrier to Entry
  • Clear Task
  • Solution Explained
  • Provides Context
  • Identifies Relevant Code
  • Gives Examples
  • Ready to Test
  • Goldilocks priority
  • Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. labels Mar 22, 2024
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 20, 2024
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akalenyu
Copy link
Contributor

/reopen

@kubevirt-bot kubevirt-bot reopened this Aug 19, 2024
@kubevirt-bot
Copy link
Contributor

@akalenyu: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhiller
Copy link
Contributor Author

dhiller commented Sep 19, 2024

/reopen
/remove-lifecycle rotten
/lifecycle frozen

@kubevirt-bot kubevirt-bot reopened this Sep 19, 2024
@kubevirt-bot
Copy link
Contributor

@dhiller: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues and PRs concerning KubeVirt Prow, i.e. configuration, setup etc. good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants