botreview, prow update: narrow down files to look at

[dhiller]

TL;DR

goal: make the botreview only look at pull requests that the review type is made for

Background

The botreview plugin has been created to automatically review pull requests that have been created by automation. It's initial implementation is intended to check expectation but it could easily extended to also check whether images are available etc.

Problem

Issue is that it currently picks up pull requests that are none of it's business. I.e. #3146 (comment) shows that the PR has been accidentally considered to be reviewed.

However, the review types are clearly made to only consider pull requests created by automation.

Task

Narrow down the pull requests to be considered per review type, such that it doesn't consider other pull requests and creates noise on it.

Suggestion: make the botreview only look at pull requests that have the correct subject for the pull request type

Subject examples

Review type1	Example PR subject2	GitHub Search Query3
bump_kubevirtci.go	Bump kubevirtci	PR Bump kubevirtci
image_update.go	Run hack/bump-prow-job-images.sh	Run hack/bump-prow-job-images.sh
kubevirt_uploader.go	Run bazelisk run //robots/cmd/uploader:uploader -- -workspace /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirt/WORKSPACE -dry-run=false	Run bazelisk ...
prow_autobump.go	Run hack/bump-prow.sh	Run hack/bump-prow.sh

Footnotes

1. The review type effectively is the implementation of the strategy for checking a set of reviews of the same type ↩

2. This is the subject of the reviews that the strategy is meant to check ↩

3. This query should yield all PRs that the strategy is meant to check ↩

[dhiller]

/kind bug

[dhiller]

/kind prow

[kubevirt-bot]

@dhiller: The label(s) kind/prow cannot be applied, because the repository doesn't have them.

In response to this:

/kind prow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhiller]

/area automatin
/area prow

[kubevirt-bot]

@dhiller: The label(s) area/automatin cannot be applied, because the repository doesn't have them.

In response to this:

/area automatin
/area prow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhiller]

/area automation

[dhiller]

/assign

[dhiller]

/unassign
/good-first-issue

[kubevirt-bot]

@dhiller:
This request has been marked as suitable for new contributors.

Guidelines

• No Barrier to Entry
• Clear Task
• Solution Explained
• Provides Context
• Identifies Relevant Code
• Gives Examples
• Ready to Test
• Goldilocks priority
• Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/unassign
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmhbnz]

I'm keen to pick this one up.

/assign

[jmhbnz]

Hey @dhiller - We met at the contribfest can you please point me to what the "good" pr's are for this bot so I can start thinking about filtering based on subject etc.

[dhiller]

Hey @jmhbnz thanks for your interest in this! I've added a subsection Subject examples to the Task section inside the issue description. Please ping me for any other questions you should have.
Thanks for reaching out and it was great talking to you IRL :)
Looking forward to your contribution 💪

[dhiller]

@jmhbnz one other thing to get you started - the func GuessReviewTypes selects the proper strategy - I'd go add the subject to the Reviewer struct and then modify it to ask each strategy whether the subject matches this review type.

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[dhiller]

/remove-lifecycle stale