Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: fails to handle creation of PRs with incompatible go module version updates #3228

Open
brianmcarey opened this issue Feb 1, 2024 · 7 comments
Labels
good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@brianmcarey
Copy link
Member

dependabot should add +incompatible to go module versions that do not start with v0 or v1

Without this errors occur when parsing go.mod leading to dependabot failing to create the update PR.

{"level":"panic","msg":"go.mod:39:2: require github.com/docker/docker: version "v24.0.7" invalid: should be v0 or v1, not v24","robot":"dependabot","time":"2024-01-30T13:23:52Z"}

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-project-infra-dependabot-update/1752320530951704576

@dhiller
Copy link
Contributor

dhiller commented Feb 1, 2024

While trying to fix this we noticed that there's a go get ./... step missing before the make gazelle-update-repos, so gazelle can add the new dependencies that are introduced after the bumps.

(since the docker/docker cve was removed manually the latest build didn't stumble over this any more)

Now we are having problems with the new external dependency @com_cloudflare_circl which misses external header files. We found this bazel gazelle issue where folks reported they patched some files to make up for missing stuff.

@brianmcarey
Copy link
Member Author

@kubevirt-bot
Copy link
Contributor

@brianmcarey:
This request has been marked as suitable for new contributors.

Guidelines

  • No Barrier to Entry
  • Clear Task
  • Solution Explained
  • Provides Context
  • Identifies Relevant Code
  • Gives Examples
  • Ready to Test
  • Goldilocks priority
  • Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Recent failure: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-project-infra-dependabot-update/1770787529876836352

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. labels Mar 22, 2024
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2024
@brianmcarey
Copy link
Member Author

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2024
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants