Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /ok-to-test bot message since it's deprecated #3360

Open
iholder101 opened this issue Apr 21, 2024 · 5 comments
Open

Remove /ok-to-test bot message since it's deprecated #3360

iholder101 opened this issue Apr 21, 2024 · 5 comments
Labels

Comments

@iholder101
Copy link
Contributor

What happened:
Today, when a non-community member submits a PR, the bot posts the following comment:

Hi @member. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

What you expected to happen:
Since the /ok-to-test label is deprecated and no longer works, so the bot should avoid such comments.

How to reproduce it (as minimally and precisely as possible):
non-community member to submit a PR

Additional context:
Example: kubevirt/kubevirt#11743 (comment)

@iholder101
Copy link
Contributor Author

FYI @dhiller @oshoval @brianmcarey

@oshoval
Copy link
Contributor

oshoval commented Apr 21, 2024

I would say update the comment to reflect the current state
but it might depend if it is internal plugin and then we need to fork test-infra (unless we are doing it already)
and then it might be too much for just this change

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 19, 2024
@iholder101
Copy link
Contributor Author

/remove-lifecycle rotten

@kubevirt-bot kubevirt-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants