Download coursier if missing #104
Draft
+183
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kubukoz
commented
Oct 1, 2022
kubukoz
commented
- Fetch coursier if missing
- Update instructions
kubukoz
commented
Feb 17, 2023
| 1. Make sure you have [Coursier](https://get-coursier.io/docs/cli-installation) available on the PATH as `cs`, running Java 11 or above | ||
| 2. Get the extension from [Marketplace](https://marketplace.visualstudio.com/items?itemName=kubukoz.smithy-playground) | ||
| 3. Create a file, `smithy-build.json`. Example: | ||
| <!-- todo: does coursier install a jvm if needed? try it in docker --> |
kubukoz
commented
Feb 17, 2023
| "smithyql" | ||
| ); | ||
|
|
||
| const coursierBinary = await getCoursierExecutable(context.extensionPath); |
Owner
Author
There was a problem hiding this comment.
this should be integration tested
kubukoz
commented
Feb 17, 2023
| "Smithy Playground", | ||
| { | ||
| command: "cs", | ||
| command:coursierBinary, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.