Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post css and fixes #69

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

MartinKavik
Copy link
Contributor

@MartinKavik MartinKavik commented Aug 31, 2017

Breaking changes in old projects

  • styles.css moved from public root to public/stylesheets/styles.css

Changes

  • see commits (fixed scss livereload, added postcss + autoreprefixer...)

Notes

  • please test before merging and maybe update readme.md
  • transforming images on image change / add / remove is not effective
  • suggestion for discussion: "Clear folder public on every server start?"

@zaiste
Copy link
Collaborator

zaiste commented Sep 1, 2017

@MartinKavik fantastic contribution, thank you! I'll review and test it in details tonight

@zaiste
Copy link
Collaborator

zaiste commented Sep 1, 2017

@MartinKavik wouldn't it be too much of trouble for you to rewrite commit messages to conform to those guidelines ? it would help us to automate changelog generation in near future. This is easily done with git rebase. I'd be also great to remove merge commit :)

@MartinKavik
Copy link
Contributor Author

@zaiste I think it will be necessary to recreate all commits and maybe split it to more branches (if I will be doing it, I want to do it well), but I'm not sure I will have time next week for this.
Can you add link to that guideline to readme.md? I was looking to Contribution Guide in readme before work, but it still returns 404.


OT: Can I ask, what was your arguments against some bigger bundlers (e.g. Webpack) and other languages (e.g. Typescript)? (I am just curious)

@zaiste
Copy link
Collaborator

zaiste commented Oct 20, 2017

@MartinKavik My apologies for the delay. Would you rebase your changes? I'll merge it right away.

@MartinKavik
Copy link
Contributor Author

@zaiste Hi, I've rebased it onto new master. So I think you can do code review, merge it and maybe squash commits. I'm not active Kulfon user now so I don't want to do some more refactor because I don't want to introduce new bugs during the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNG reference Switch to PostCSS Support for sourcemaps
2 participants