-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post css and fixes #69
base: master
Are you sure you want to change the base?
Conversation
@MartinKavik fantastic contribution, thank you! I'll review and test it in details tonight |
@MartinKavik wouldn't it be too much of trouble for you to rewrite commit messages to conform to those guidelines ? it would help us to automate changelog generation in near future. This is easily done with |
@zaiste I think it will be necessary to recreate all commits and maybe split it to more branches (if I will be doing it, I want to do it well), but I'm not sure I will have time next week for this. OT: Can I ask, what was your arguments against some bigger bundlers (e.g. Webpack) and other languages (e.g. Typescript)? (I am just curious) |
@MartinKavik My apologies for the delay. Would you rebase your changes? I'll merge it right away. |
@zaiste Hi, I've rebased it onto new master. So I think you can do code review, merge it and maybe squash commits. I'm not active Kulfon user now so I don't want to do some more refactor because I don't want to introduce new bugs during the process. |
Breaking changes in old projects
public/stylesheets/styles.css
Changes
Notes
images
on image change / add / remove is not effectivepublic
on every server start?"