Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that you should only use helm chart version equal to binary version #2143

Open
lahabana opened this issue Dec 11, 2024 · 1 comment
Open

Indicate that you should only use helm chart version equal to binary version #2143

lahabana opened this issue Dec 11, 2024 · 1 comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

What happened?

With kumahq/kuma#8199 we removed the env var KUMA_DATAPLANE_NAME from the ingress/egress chart.

This causes an issue when customers do:

  1. upgrade helm chart but pin to old binary version
  2. install changes the deployment manifest and restart ingress/egress
  3. restart fails because version < 2.5 need KUMA_DATAPLANE_NAME to be set.

We should add back this env var in 2.6 and 2.7 as the feature was added in 2.5 we only need to support this for the next 2 versions.
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Dec 11, 2024
lahabana referenced this issue in lahabana/kuma Dec 11, 2024
@lahabana
fix(helm): add back KUMA_DATAPLANE_NAME to egress/ingress deployment
236c5ed 
In 2.5.x we introduced a change to not rely on composed env var.

However, sometimes folks update helm before their binaries.
Therefore we introduce the removed env var to be able to run 2.4 proxies
with helm charts for version 2.6 and 2.7

fix #12241

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Dec 11, 2024
Draft
@lukidzi
Copy link
Contributor

lukidzi commented Dec 16, 2024

Triage: Should we support this? If required for upgrades we can fix it but we shouldn't support different helm version with different image version

@lukidzi lukidzi added triage/needs-information Reviewed and some extra information was asked to the reporter and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 16, 2024
@lahabana lahabana transferred this issue from kumahq/kuma Dec 23, 2024
@github-actions github-actions bot added the triage/pending This issue will be looked at on the next triage meeting label Dec 23, 2024
@lahabana lahabana changed the title ingress can fail to start when restarting with helm chart > 2.5 but binary version < 2.4 Indicate that you should only use helm chart version equal to binary version Dec 23, 2024
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting triage/needs-information Reviewed and some extra information was asked to the reporter labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lahabana @lukidzi