Better detection if we have a typedef or an inlined JSDoc object (#180)

* Better detection if we have a typedef or a inlined JSDoc object

* Add unit test for syntax

Author: kungfooman

src-transpiler/Asserter.js

@@ -504,7 +504,8 @@ class Asserter extends Stringifier {
               }
               continue;
             } else if (param.left.type === 'ObjectPattern') {
-              if (type.type === 'object') {
+              // If we have properties from JSDoc, we can create individual type inspections.
+              if (type?.properties && Object.keys(type.properties).length) {
                 // Add a type assertion for each property of the ObjectPattern
                 for (const property of param.left.properties) {
                   if (property.type !== 'ObjectProperty') {
@@ -540,7 +541,7 @@ class Asserter extends Stringifier {
                   out += `${spaces}  youCanAddABreakpointHere();\n${spaces}}\n`;
                 }
                 continue;
-              } else if (typeof type === 'string') {
+              } else {
                 // The case when we have an ObjectPattern with a @typedef
                 name = `arguments[${paramIndex}]`;
               }

test/typechecking.json

@@ -127,6 +127,10 @@
     "input": "./test/typechecking/simple-ObjectPattern-rest-input.mjs",
     "output": "./test/typechecking/simple-ObjectPattern-rest-output.mjs"
   },
+  {
+    "input": "./test/typechecking/simple-ObjectPattern-typedef-2-input.mjs",
+    "output": "./test/typechecking/simple-ObjectPattern-typedef-2-output.mjs"
+  },
   {
     "input": "./test/typechecking/simple-ObjectPattern-typedef-input.mjs",
     "output": "./test/typechecking/simple-ObjectPattern-typedef-output.mjs"

test/typechecking/simple-ObjectPattern-typedef-2-input.mjs

@@ -0,0 +1,12 @@
+/**
+ * @param {PretrainedOptions} [something] Optional parameters.
+ */
+function test(
+  {
+    revision = 'main',
+  } = {}
+) {
+  return revision;
+}
+const ret = test();
+console.log('ret', ret);

test/typechecking/simple-ObjectPattern-typedef-2-output.mjs

@@ -0,0 +1,16 @@
+/**
+ * @param {PretrainedOptions} [something] Optional parameters.
+ */
+function test({
+  revision = 'main',
+} = {}) {
+  if (!inspectType(arguments[0], {
+    "type": "PretrainedOptions",
+    "optional": true
+  }, 'test', 'something')) {
+    youCanAddABreakpointHere();
+  }
+  return revision;
+}
+const ret = test();
+console.log('ret', ret);