Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP: configuration option for a Custom CA #359

Open
pvogler opened this issue Sep 27, 2024 · 4 comments
Open

HTTP: configuration option for a Custom CA #359

pvogler opened this issue Sep 27, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@pvogler
Copy link

pvogler commented Sep 27, 2024

Feature Description

With issue report #337 HTTP tls verification for v1 was implemented.
In fact this feature is missing in version 2 and the master branch.

Easy way would be to upstream the verification skipping, but I would prefer to allow an option to configure a custom ca or disable verification manually.

Version of logstash-exporter this feature request applies to

v2

Motivation and Goals

Motivation is, to get the exporter working out of the box also with the ECK operator deployment.

Alternatives Considered

Disabling TLS on Logstash side would work as well, but from security perspective this is not a good way.

Additional Context

No response

@pvogler pvogler added the enhancement New feature or request label Sep 27, 2024
@satk0
Copy link
Collaborator

satk0 commented Sep 30, 2024

Good catch, I could rewrite it for v2

@pvogler
Copy link
Author

pvogler commented Oct 2, 2024

If you provide a nightly image, I would be happy to test it for you.

@satk0
Copy link
Collaborator

satk0 commented Oct 2, 2024

Thanks in advance, it would sure be a huge help! Right now, I am still waiting for @kuskoman to finally merge my hot-reload PR 😮‍💨

I honestly can't wait to start working on it, I have the right mood and motivation to do it 😄

satk0 added a commit to satk0/logstash-exporter that referenced this issue Oct 30, 2024
satk0 added a commit to satk0/logstash-exporter that referenced this issue Oct 30, 2024
@satk0
Copy link
Collaborator

satk0 commented Oct 30, 2024

Done in #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants