Implement confidential statement #4910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
approved these changes
Feb 15, 2025
| auto isSuccess = queryResult->isSuccess(); | ||
| queryResults.push_back(std::move(queryResult)); | ||
| if (isSuccess && !database->getConfig().readOnly) { | ||
| auto clientContext = conn->getClientContext(); |
There was a problem hiding this comment.
This looks fine to me. @ray6080 can u take a second look?
There was a problem hiding this comment.
hmm I'm concerned about this approach because it introduces an additional binding step to every write query, which I don't think the overhead is insignificant. Need to think a bit on what's an alternative way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the confidential statement.
A statement is considered as confidential if it contains user's secrets (password, key).
Shell is not going to record those statements;
Fixes #4891