Skip to content

Commit 19aafbe

Browse files
authored
[TransferEngine] fix: add auto_discover in transfer_engine_c (#87)
* fix transfer_engine_c * fix rust and go examples
1 parent dd10d65 commit 19aafbe

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

mooncake-p2p-store/src/p2pstore/transfer_engine.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ func NewTransferEngine(metadata_uri string, local_server_name string, nic_priori
7171
defer C.free(unsafe.Pointer(localServerName))
7272
defer C.free(unsafe.Pointer(connectableName))
7373

74-
native_engine := C.createTransferEngine(metadataUri, localServerName, connectableName, C.uint64_t(rpc_port))
74+
auto_discover := 0 // disable auto_discover
75+
native_engine := C.createTransferEngine(metadataUri, localServerName, connectableName, C.uint64_t(rpc_port), C.uint64_t(auto_discover))
7576
if native_engine == nil {
7677
return nil, ErrTransferEngine
7778
}

mooncake-transfer-engine/include/transfer_engine_c.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ typedef void *transport_t;
9696
transfer_engine_t createTransferEngine(const char *metadata_conn_string,
9797
const char *local_server_name,
9898
const char *ip_or_host_name,
99-
uint64_t rpc_port);
99+
uint64_t rpc_port,
100+
int auto_discover);
100101

101102
transport_t installTransport(transfer_engine_t engine, const char *proto,
102103
void **args);

mooncake-transfer-engine/rust/src/transfer_engine.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ impl TransferEngine {
8181
local_server_name_c.as_ptr(),
8282
local_server_name_c.as_ptr(),
8383
rpc_port,
84+
0, // disable auto_discover
8485
)
8586
};
8687
if engine.is_null() {

mooncake-transfer-engine/src/transfer_engine_c.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ using namespace mooncake;
2525
transfer_engine_t createTransferEngine(const char *metadata_conn_string,
2626
const char *local_server_name,
2727
const char *ip_or_host_name,
28-
uint64_t rpc_port) {
29-
TransferEngine *native = new TransferEngine();
28+
uint64_t rpc_port,
29+
int auto_discover) {
30+
TransferEngine *native = new TransferEngine(auto_discover);
3031
int ret = native->init(metadata_conn_string, local_server_name,
3132
ip_or_host_name, rpc_port);
3233
if (ret) {

0 commit comments

Comments
 (0)