Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kwil-cli account transfer recipient does not work as expected #1268

Closed
brennanjl opened this issue Jan 21, 2025 · 3 comments · Fixed by #1254
Closed

kwil-cli account transfer recipient does not work as expected #1268

brennanjl opened this issue Jan 21, 2025 · 3 comments · Fixed by #1254
Assignees
@charithabandi
Milestone
v0.10

Comments

@brennanjl
Copy link
Collaborator

kwil-cli account transfer does not support reading in Ethereum 0x addresses. See here:

kwil-db/cmd/kwil-cli/cmds/account/transfer.go

Line 38 in d3a5fa9

id, err := hex.DecodeString(recipient)

@brennanjl brennanjl added this to the v0.10 milestone Jan 21, 2025
@charithabandi
Copy link
Contributor

charithabandi commented Jan 21, 2025 •
edited
Loading

kwil-cli account balance should be changed too. All the CLI's which takes accounts have been modified to accept compactID rather than the identifier.

@charithabandi charithabandi self-assigned this Jan 22, 2025
@jchappelow
Copy link
Member

I think #1254 resolves these too #1268

@charithabandi charithabandi linked a pull request Jan 23, 2025 that will close this issue
custom key types #1254
Merged
@charithabandi
Copy link
Contributor

#1254 fixes this. Tested it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charithabandi charithabandi

Labels
None yet
Projects
None yet
Milestone
v0.10
Development

Successfully merging a pull request may close this issue.

custom key types jchappelow/kwil-db
3 participants
@charithabandi @brennanjl @jchappelow