Skip to content
This repository has been archived by the owner on May 15, 2021. It is now read-only.

Unmutes audio when it shouldn't #36

Open
kylecorry31 opened this issue Feb 7, 2019 · 4 comments
Open

Unmutes audio when it shouldn't #36

kylecorry31 opened this issue Feb 7, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@kylecorry31
Copy link
Owner

Developer fixing.

@kylecorry31 kylecorry31 added the bug Something isn't working label Feb 7, 2019
@kylecorry31 kylecorry31 reopened this Feb 7, 2019
@kylecorry31
Copy link
Owner Author

It needs to be able to detect if the audio is muted, and this may be tricky

@kylecorry31
Copy link
Owner Author

kylecorry31 commented Apr 3, 2019

States:
DND enabled -> audio was muted already (do nothing) -> DND disabled -> audio stays muted (do nothing)
DND enabled -> audio not muted (mute) -> DND disabled -> audio not muted (unmute)
DND enabled -> audio not muted (mute) -> user unmutes audio -> user mutes audio -> DND disabled -> audio stays muted (do nothing)

@rnhurt
Copy link

rnhurt commented Apr 16, 2019

I've noticed that the audio unmutes when the screensaver/blank screen activates. I can actually hear my speakers click a little bit when my screen fades out. Is that a symptom of this bug or a different issue?

@kylecorry31
Copy link
Owner Author

That problem is because it unmutes the audio when the extension is disabled if the setting is on for that, and because it can't tell if it was already muted (this bug), it just unmutes it. Until it is fixed, I would recommend just turning off the setting to mute audio. But honestly, I am considering just removing the mute feature because it has a lot of edge cases that are undesirable both if handled or left alone for some people

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants