Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tutorials #130

Open
eddycharly opened this issue May 15, 2023 · 8 comments
Open

Add more tutorials #130

eddycharly opened this issue May 15, 2023 · 8 comments

Comments

@eddycharly
Copy link
Member

  • API/service call
  • ConfigMap context
  • UPDATE operation
  • DELETE operation
  • imageReferences context
  • Subject
  • ClusterRole
  • Namespace labels
  • verifyImages signature
  • verifyImages attestation
  • Custom Resource (like cert-manager or Policy Exception)
@chipzoller
Copy link

For UPDATE and DELETE tests, how would this support providing an oldObject resource? That is a requirement to making these types of policies fully functional.

@fjogeleit
Copy link
Member

fjogeleit commented May 22, 2023

I think the general support in the backend part is not a big deal. More important is how we would integrate it in the UI.

  • Providing a new Panel for it and when where to place it?
  • Could image a switch icon for the resource panel in a diff mode -> oldObject left updated one right. (Like the diff editor for mutation details). But Resources panel is already small, maybe we should change the space division to 50% / 50%.

Is for deletion the oldObject == current resource? Because a deletion don't change the resource beforehand?

@chipzoller
Copy link

A couple ideas on where/how to provide oldObject:

  1. Provide a second panel called "Old Resource" which is either collapsed by default and visible (the bar only), or have this be accessible only if a user goes to the Options menu to enable Old Resource. If so, at that time it will be made visible.
  2. In the existing Resources panel, perhaps we could come up with some special field markers, comments, or something which indicate the next resource is the old resource. In this way, we reuse the Resources panel and don't clutter the screen further.

Is for deletion the oldObject == current resource? Because a deletion don't change the resource beforehand?

Yes, that is correct, so probably don't need oldObject specifically. Engine should interpret the provided resource(s) as the old object.

@chipzoller
Copy link

Could image a switch icon for the resource panel in a diff mode -> oldObject left updated one right. (Like the diff editor for mutation details). But Resources panel is already small, maybe we should change the space division to 50% / 50%.

This is also a good idea.

@fjogeleit
Copy link
Member

fjogeleit commented May 22, 2023

rough test how it would look like:

maybe we can switch it automatically when the operation is "UPDATE"

Bildschirmfoto 2023-05-22 um 13 33 07

@chipzoller
Copy link

I think that's reasonable. Needs to be a banner/title to show which split pane is new and which is old.

maybe we can switch it automatically when the operation is "UPDATE"

That's going to be basically impossible as there are many ways the operation can be specified. I don't think we want to try and be this smart but instead give users a button where they can click if they know they need an oldObject. And then if it tests and one isn't supplied, throw an error during testing that the oldObject is missing.

@fjogeleit
Copy link
Member

fjogeleit commented May 22, 2023

okay, will discuss with @eddycharly how we can implement/validate it.

@eddycharly
Copy link
Member Author

Looks good but should not block the current milestone IMO.

I wonder if we want to keep the context in yaml form or switch to a dialog/form ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants