From 4ae4ec8339a00a1917ef4e563ec8732384ba5157 Mon Sep 17 00:00:00 2001
From: Frank Jogeleit <frank.jogeleit@lovoo.com>
Date: Sun, 28 Apr 2024 14:18:48 +0200
Subject: [PATCH] target tests

Signed-off-by: Frank Jogeleit <frank.jogeleit@lovoo.com>
---
 pkg/target/kinesis/kinesis.go      |  3 +--
 pkg/target/s3/s3.go                |  3 +--
 pkg/target/ui/ui_test.go           | 14 ++++++++++++++
 pkg/target/webhook/webhook_test.go | 16 ++++++++++++++++
 4 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/pkg/target/kinesis/kinesis.go b/pkg/target/kinesis/kinesis.go
index f002c406..5c6c10a0 100644
--- a/pkg/target/kinesis/kinesis.go
+++ b/pkg/target/kinesis/kinesis.go
@@ -52,8 +52,7 @@ func (c *client) Send(result v1alpha2.PolicyReportResult) {
 	t := time.Unix(result.Timestamp.Seconds, int64(result.Timestamp.Nanos))
 	key := fmt.Sprintf("%s-%s-%s", result.Policy, result.ID, t.Format(time.RFC3339Nano))
 
-	err := c.kinesis.Upload(body, key)
-	if err != nil {
+	if err := c.kinesis.Upload(body, key); err != nil {
 		zap.L().Error("kinesis upload error", zap.String("name", c.Name()), zap.Error(err))
 		return
 	}
diff --git a/pkg/target/s3/s3.go b/pkg/target/s3/s3.go
index 04c6412b..0999f64e 100644
--- a/pkg/target/s3/s3.go
+++ b/pkg/target/s3/s3.go
@@ -54,8 +54,7 @@ func (c *client) Send(result v1alpha2.PolicyReportResult) {
 	t := time.Unix(result.Timestamp.Seconds, int64(result.Timestamp.Nanos))
 	key := fmt.Sprintf("%s/%s/%s-%s-%s.json", c.prefix, t.Format("2006-01-02"), result.Policy, result.ID, t.Format(time.RFC3339Nano))
 
-	err := c.s3.Upload(body, key)
-	if err != nil {
+	if err := c.s3.Upload(body, key); err != nil {
 		zap.L().Error(c.Name()+": S3 Upload error", zap.Error(err))
 		return
 	}
diff --git a/pkg/target/ui/ui_test.go b/pkg/target/ui/ui_test.go
index 9da0c6d5..192b6f3c 100644
--- a/pkg/target/ui/ui_test.go
+++ b/pkg/target/ui/ui_test.go
@@ -60,4 +60,18 @@ func Test_UITarget(t *testing.T) {
 			t.Errorf("Unexpected Name %s", client.Name())
 		}
 	})
+	t.Run("Request Error", func(t *testing.T) {
+		callback := func(req *http.Request) {
+			t.Fail()
+		}
+
+		client := ui.NewClient(ui.Options{
+			ClientOptions: target.ClientOptions{
+				Name: "UI",
+			},
+			Host:       "\\localhost:8080",
+			HTTPClient: testClient{callback, 200},
+		})
+		client.Send(fixtures.CompleteTargetSendResult)
+	})
 }
diff --git a/pkg/target/webhook/webhook_test.go b/pkg/target/webhook/webhook_test.go
index e429d010..d7290cd3 100644
--- a/pkg/target/webhook/webhook_test.go
+++ b/pkg/target/webhook/webhook_test.go
@@ -76,4 +76,20 @@ func Test_UITarget(t *testing.T) {
 			t.Errorf("Unexpected Name %s", client.Name())
 		}
 	})
+	t.Run("Request Error", func(t *testing.T) {
+		callback := func(req *http.Request) error {
+			t.Fail()
+
+			return nil
+		}
+
+		client := webhook.NewClient(webhook.Options{
+			ClientOptions: target.ClientOptions{
+				Name: "UI",
+			},
+			Host:       "\\localhost:8080",
+			HTTPClient: testClient{callback, 200},
+		})
+		client.Send(fixtures.CompleteTargetSendResult)
+	})
 }