Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with netstandard #5

Open
pkese opened this issue Aug 29, 2017 · 5 comments · Fixed by #6
Open

Doesn't work with netstandard #5

pkese opened this issue Aug 29, 2017 · 5 comments · Fixed by #6

Comments

@pkese
Copy link

pkese commented Aug 29, 2017

Hi,

I've been using this library for a while and I like ti very much. It is also one of the most popular cloning libraries on nuget.

However I've recently started porting my project to netstandard and the compiler is complaining, that GeorgeCloney needs the old dotnet 4.x. Therefore I'm stuck.

Since there aren't any external dependencies in GeorgeCloney, I think it wouldn't be too hard to target this library to netstandard instead of net 4.x (e.g. usually netstandard 1.3 is the lowest common denomintor that works anywhere).

Any chance you'd be willing to do that.

@laazyj
Copy link
Owner

laazyj commented Sep 3, 2017

Thanks for getting in touch. It's a very good point and something I'll have a look at.
But it might take me a few weeks to get to it. If you need it sooner I'd suggest having a go at the change and sending me a pull request.

@McDoit
Copy link
Contributor

McDoit commented Jul 20, 2020

@laazyj Is this project dead or any chance to look at the PR? ;)

@laazyj laazyj closed this as completed in #6 Jul 22, 2020
laazyj added a commit that referenced this issue Jul 22, 2020
Resolves #5 - Doesn't work with netstandard
@laazyj laazyj reopened this Jul 22, 2020
@laazyj
Copy link
Owner

laazyj commented Jul 22, 2020

build.cmd doesn't support the new project format so AppVeyor CI failed and no new Nuget package published.

I'm not in a position to continue to support this project so I'd be happy to hand over ownership of it to anyone that is interested in maintaining it... @McDoit @pkese ?

@steenlknudsen
Copy link
Collaborator

i would like to maintain it

@laazyj
Copy link
Owner

laazyj commented Aug 8, 2020

Hi @steenlknudsen I've added you as a collaborator on the repository. What's your Nuget username so I can make you an owner of the package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants