improve gRPC robustness #1574
Merged
improve gRPC robustness #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
If an acquire or release failed on the exporter, we should add the reason to the exception. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
…pired Event if the caller has given up on this command, we should at least report if we receive a reply later. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Handle acquire/release calls for already acquired/released resources as errors by raising an exception and providing the reason to the coordinator. That also means that these calls will now return an error to the coordinator. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
jluebbe
force-pushed
the
improve-grpc-robustness
branch
from
1fbda8c to
396af5d
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
========================================
- Coverage 56.2% 56.1% -0.1%
========================================
Files 170 170
Lines 13248 13265 +17
========================================
+ Hits 7449 7453 +4
- Misses 5799 5812 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
Jan 22, 2025
Bastian-Krause
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These check for some corner cases that we've seen in your lab and handle them better.