fix(validation): add count on validation resource #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balsir
requested changes
Dec 5, 2025
modules/addon/validations.tf
Outdated
| } | ||
| } | ||
|
|
||
| moved { |
Contributor
There was a problem hiding this comment.
Please move this to a moved.tf file.
Btw in this case, the moved block is not necessary, but recommended: https://developer.hashicorp.com/terraform/language/modules/develop/refactoring#enable-count-or-for_each-for-a-resource
Riqardos
force-pushed
the
validation-enabled
branch
from
0465c3d to
0655411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After disabling universal-addon,
resource "terraform_data" "validations"isn't deleted.Current CR shouldn't introduce BC.
Type of change
fix)feat)refactor)test)style)ci)docs)How Has This Been Tested?
Tested by enabling/disabling addon.