Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None value fields are not being handled correctly in ContainerRegistryNode GQL #3698

Closed
jopemachine opened this issue Feb 13, 2025 — with Lablup-Issue-Syncer · 1 comment
Assignees

Comments

@jopemachine
Copy link
Member

Summary  

  • Values in the database should not be changed when no value is provided.

Steps to Reproduce  

  1. Update the registry information in the WebUI and call the ModifyContainerRegistryNode API.
  2. Check how the values of fields, when not provided, are changed in the database

Expected Behavior  

  • Values in the database should not be changed when no value is provided.

Actual Behavior  

  • Fields not provided, are changed to NULL in the database.

Logs/Errors  

None

@jopemachine
Copy link
Member Author

If we treat null as a missing value, it causes an issue where we can't insert null into nullable columns like DB username and password.

This issue can be resolved by using the new V2 mutation introduced in #3418.
So I'll close this PR as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant