Skip to content

Commit d780a78

Browse files
committed
add lock option v2 and do not import client v2 in __init__
1 parent cd38d66 commit d780a78

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

docs/references.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -829,6 +829,8 @@ alias of `rpc_pb2.DeleteRangeRequest`
829829

830830
### _class_ etcetra.types.EtcdLockOption(lock_name: 'str', timeout: 'Optional[float]', ttl: 'Optional[int]')
831831

832+
### _class_ etcetra.types.EtcdLockOptionV2(lock_name: 'bytes', timeout: 'Optional[float]', ttl: 'Optional[int]')
833+
832834
### _class_ etcetra.types.HostPortPair(host: 'str', port: 'int')
833835

834836
### etcetra.types.PutRequestType()

src/etcetra/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@
44

55
__all__ = (
66
*_client.__all__,
7-
*_client_v2.__all__,
87
*_types.__all__,
98
)
109

1110
from .client import * # noqa
12-
from .client_v2 import * # noqa
1311
from .types import * # noqa
1412

1513
__version__ = '0.1.18'

src/etcetra/client_v2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from .grpc_api import rpc_pb2, rpc_pb2_grpc
2525
from .grpc_api import v3lock_pb2, v3lock_pb2_grpc
2626
from .types import (
27-
DeleteRangeRequestType, EtcdCredential, EtcdLockOption, HostPortPair,
27+
DeleteRangeRequestType, EtcdCredential, EtcdLockOptionV2 as EtcdLockOption, HostPortPair,
2828
PutRequestType, RangeRequestSortOrder, RangeRequestSortTarget, RangeRequestType,
2929
TransactionRequest, TxnReturnType, TxnReturnValues, WatchCreateRequestFilterType,
3030
WatchEvent, WatchEventType,
@@ -130,7 +130,7 @@ def connect(self) -> EtcdConnectionManager:
130130

131131
def with_lock(
132132
self,
133-
lock_name: str,
133+
lock_name: bytes,
134134
timeout: Optional[float] = None,
135135
ttl: Optional[int] = None,
136136
) -> EtcdConnectionManager:

src/etcetra/types.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,3 +189,9 @@ class EtcdLockOption:
189189
lock_name: str
190190
timeout: Optional[float]
191191
ttl: Optional[int]
192+
193+
@dataclass
194+
class EtcdLockOptionV2:
195+
lock_name: bytes
196+
timeout: Optional[float]
197+
ttl: Optional[int]

0 commit comments

Comments
 (0)