From 86fddf40393e3dc31b076d9ef016afb91ba7a512 Mon Sep 17 00:00:00 2001 From: Chris Mackey Date: Mon, 18 Nov 2024 10:56:25 -0800 Subject: [PATCH] fix(model): Ensure that model comparison converts to the same units --- honeybee_display/model.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/honeybee_display/model.py b/honeybee_display/model.py index f28b8ac..662122f 100644 --- a/honeybee_display/model.py +++ b/honeybee_display/model.py @@ -480,6 +480,12 @@ def model_comparison_to_vis_set( incoming_color: An optional ladybug Color to set the color of the incoming model. If None, a default red color will be used. (Default: None). """ + # make sure that both models have the same units system + original_units = None + if base_model.units != incoming_model.units: + original_units = incoming_model.units + incoming_model.convert_to_units(base_model.units) + # set the default colors if not provided if base_color is None: base_color = Color(98, 190, 190, 128) @@ -535,6 +541,9 @@ def model_comparison_to_vis_set( incoming_windows.display_name = 'Incoming Windows' vis_set.add_geometry(incoming_windows) + # put back the original units if different + if original_units is not None: + incoming_model.convert_to_units(original_units) return vis_set