From dff31fdc09640fefec6dd591446ec7a9c70d6531 Mon Sep 17 00:00:00 2001 From: Samuel Felton Date: Tue, 24 Sep 2024 14:56:18 +0200 Subject: [PATCH] Fix lto optimization generating cmake errors --- modules/python/bindings/CMakeLists.txt | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/modules/python/bindings/CMakeLists.txt b/modules/python/bindings/CMakeLists.txt index 55864de695..cd525fd570 100644 --- a/modules/python/bindings/CMakeLists.txt +++ b/modules/python/bindings/CMakeLists.txt @@ -49,17 +49,15 @@ file(MAKE_DIRECTORY "${bindings_gen_location}/src") get_target_property(PYTHON_CXX_FLAGS _visp COMPILE_OPTIONS) get_target_property( PYTHON_LINKER_FLAGS _visp LINK_OPTIONS) - -set_target_properties(_visp PROPERTIES COMPILE_FLAGS ${PYTHON_CXX_FLAGS}) if(PYTHON_CXX_FLAGS STREQUAL "PYTHON_CXX_FLAGS-NOTFOUND") SET(PYTHON_CXX_FLAGS "") # Set to empty string else() - SET(PYTHON_CXX_FLAGS "${PYTHON_CXX_FLAGS} ") # A space to cleanly separate from existing content + SET(PYTHON_CXX_FLAGS "${PYTHON_CXX_FLAGS}") endif() if(PYTHON_LINKER_FLAGS STREQUAL "PYTHON_LINKER_FLAGS-NOTFOUND") -SET(PYTHON_LINKER_FLAGS "") # Set to empty string + SET(PYTHON_LINKER_FLAGS "") # Set to empty string else() -SET(PYTHON_LINKER_FLAGS "${PYTHON_LINKER_FLAGS} ") # A space to cleanly separate from existing content + SET(PYTHON_LINKER_FLAGS "${PYTHON_LINKER_FLAGS}") endif() CHECK_CXX_COMPILER_FLAG("-flto=auto" COMPILER_SUPPORTS_FLTOAUTO) if(COMPILER_SUPPORTS_FLTOAUTO) @@ -67,9 +65,10 @@ if(COMPILER_SUPPORTS_FLTOAUTO) SET(PYTHON_LINKER_FLAGS "${PYTHON_LINKER_FLAGS} -flto=auto") endif() -set_target_properties(_visp PROPERTIES COMPILE_FLAGS ${PYTHON_CXX_FLAGS}) -set_target_properties(_visp PROPERTIES LINK_FLAGS ${PYTHON_LINKER_FLAGS}) - +if(NOT PYTHON_CXX_FLAGS STREQUAL "") + set_target_properties(_visp PROPERTIES COMPILE_FLAGS ${PYTHON_CXX_FLAGS}) + set_target_properties(_visp PROPERTIES LINK_FLAGS ${PYTHON_LINKER_FLAGS}) +endif() set_target_properties(_visp PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}"