From 709f8a290fb311532b4254108621ddc2716bd04e Mon Sep 17 00:00:00 2001 From: Martin Paulucci Date: Mon, 20 Jan 2025 17:44:37 +0100 Subject: [PATCH] ci(core): fix reports to slack channels (#1744) **Motivation** Lets go back to the previous l1 slack channel for reports **Description** - Fixes issue with commas that break the for loop (should be only spaces) - Added some linting and safety code --- .github/workflows/ci_gha.yaml | 2 +- .github/workflows/daily_loc.yaml | 4 ++-- .github/workflows/daily_reports.yaml | 7 ++++--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci_gha.yaml b/.github/workflows/ci_gha.yaml index cd48dd97b0..493a3ca068 100644 --- a/.github/workflows/ci_gha.yaml +++ b/.github/workflows/ci_gha.yaml @@ -3,7 +3,7 @@ on: pull_request: branches: ["**"] paths: - ".github/**.yaml" + - ".github/**.yaml" concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} diff --git a/.github/workflows/daily_loc.yaml b/.github/workflows/daily_loc.yaml index 91a7f7b7b6..dc481efd6d 100644 --- a/.github/workflows/daily_loc.yaml +++ b/.github/workflows/daily_loc.yaml @@ -60,8 +60,8 @@ jobs: ${{ github.event_name == 'workflow_dispatch' && secrets.TEST_CHANNEL_SLACK || format( - '{0}, {1}, {2}', - secrets.ETHREX_REPORTS_SLACK_WEBHOOK, + '{0} {1} {2}', + secrets.ETHREX_L1_SLACK_WEBHOOK, secrets.ETHREX_L2_SLACK_WEBHOOK, secrets.LEVM_SLACK_WEBHOOK ) diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index 29e264aa3e..29a2bc881e 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -108,8 +108,9 @@ jobs: ${{ github.event_name == 'workflow_dispatch' && secrets.TEST_CHANNEL_SLACK || format( - '{0}, {1}', - secrets.ETHREX_REPORTS_SLACK_WEBHOOK, + '{0} {1} {2}', + secrets.ETHREX_L1_SLACK_WEBHOOK, + secrets.ETHREX_L2_SLACK_WEBHOOK, secrets.LEVM_SLACK_WEBHOOK ) }} @@ -196,4 +197,4 @@ jobs: && secrets.TEST_CHANNEL_SLACK || secrets.LEVM_SLACK_WEBHOOK }} - run: sh .github/scripts/publish_levm_ef_tests.sh $SLACK_WEBHOOK + run: sh .github/scripts/publish_levm_ef_tests.sh "$SLACK_WEBHOOK"