LEVM: Add LegacyTests to the LEVM EF tests suite
#1701
Comments
ilitteri
added
ef-tests
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 6, 2025
**Motivation** <!-- Why does this pull request exist? What are its goals? --> This pull request introduces changes to the Ethereum Foundation (EF) test framework, specifically enhancing the handling of forks within the test reports. The changes include modifications to the deserialization process, test report structure, and test runner logic to support multiple forks. **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> * `cmd/ef_tests/levm/report.rs`: Refactored `EFTestReport` to include `fork_results` instead of a single `fork` field. Introduced `EFTestReportForkResult` to encapsulate fork-specific results. Updated methods to handle the new structure and ensure correct reporting of test results per fork. * `cmd/ef_tests/levm/runner/levm_runner.rs`: Updated the `run_ef_test` and `run_ef_test_tx` functions to iterate over forks and handle fork-specific test execution. Adjusted `prepare_vm_for_tx` and `ensure_post_state` functions to accept a `fork` parameter. * `cmd/ef_tests/levm/runner/mod.rs`: Handled cases where test hashes might be missing to prevent panics. * `cmd/ef_tests/levm/runner/revm_runner.rs`: Updated imports to include `EFTestReportForkResult`. Closes #1701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add the EF tests GitHub submodule
LegacyTeststo our current suite.This submodule has three directories
BasicTests,Constantinople, andCancun. Each of these contains aGeneralStateTestssubdirectory.The idea is to add
LegacyTests/BasicTests/GeneralStateTests/,LegacyTests/Constantinople/GeneralStateTests/, andLegacyTests/Cancun/GeneralStateTests/to our suite.The text was updated successfully, but these errors were encountered: