From 2dccc096196cc540d80b43c146fdf2beaee2617c Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 16:23:56 -0300 Subject: [PATCH 01/24] test: ci --- crates/vm/levm/src/vm.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 85083c16f0..156d57e98c 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,9 +950,11 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { - delegation_bytes.into() - } else { + //delegation_bytes.into() Bytes::new() + } else { + //Bytes::new() + delegation_bytes.into() }; // 9. Increase the nonce of authority by one. From f2887741fc89d5c0527511716069833a36fb5fe5 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:04:07 -0300 Subject: [PATCH 02/24] refactor: ci --- .github/workflows/ci_bench_levm_in_pr.yaml | 7 ++++--- .github/workflows/daily_reports.yaml | 10 ++++++++++ crates/vm/levm/src/vm.rs | 6 ++---- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci_bench_levm_in_pr.yaml b/.github/workflows/ci_bench_levm_in_pr.yaml index 9833c5ec67..74cac06e6b 100644 --- a/.github/workflows/ci_bench_levm_in_pr.yaml +++ b/.github/workflows/ci_bench_levm_in_pr.yaml @@ -2,7 +2,7 @@ name: Benchmark LEVM vs REVM in PR on: pull_request: - branches: [ "**" ] + branches: ["**"] paths: - "crates/vm/levm/**" @@ -104,7 +104,7 @@ jobs: combine-results: name: Combine Benchmark Results runs-on: ubuntu-latest - needs: [ benchmark-pr, benchmark-main ] + needs: [benchmark-pr, benchmark-main] steps: - name: Download PR results uses: actions/download-artifact@v4 @@ -174,6 +174,7 @@ jobs: cd crates/vm/levm && awk '/Summary: /,/Frontier/' test_result.txt; - name: Check EF-TESTS status is 100% + id: check_tests run: | cd crates/vm/levm if [ "$(awk '/Summary:/ {print $(NF)}' test_result.txt)" != "(100.00%)" ]; then @@ -201,7 +202,7 @@ jobs: body-includes: "Summary:" - name: Create Comment - if: ${{ github.event_name == 'pull_request' }} + if: ${{ steps.check_tests.outcome == 'failure' && github.event_name == 'pull_request' }} uses: peter-evans/create-or-update-comment@v4 with: comment-id: ${{ steps.fc.outputs.comment-id }} diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index 7b5640dff1..09fd3d6a60 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -190,7 +190,17 @@ jobs: echo "# Daily LEVM EF Tests Run Report" >> $GITHUB_STEP_SUMMARY cat cmd/ef_tests/levm/levm_ef_tests_summary_github.txt >> $GITHUB_STEP_SUMMARY + - name: Check EF-TESTS status is 100% + id: check_tests + run: | + cd crates/vm/levm + if [ "$(awk '/**Summary**:/ {print $(NF)}' cmd/ef_tests/levm/levm_ef_tests_summary_github.txt)" != "(100.00%)" ]; then + echo "Percentage is not 100%." + exit 1 + fi + - name: Post results to Slack + if: ${{steps.check_tests.outcome == 'failure'}} env: SLACK_WEBHOOK: > ${{ github.event_name == 'workflow_dispatch' diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 156d57e98c..85083c16f0 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,11 +950,9 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { - //delegation_bytes.into() - Bytes::new() - } else { - //Bytes::new() delegation_bytes.into() + } else { + Bytes::new() }; // 9. Increase the nonce of authority by one. From 008dea7e9a8f2b0e21c1ab19803bcff85ba5c163 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:08:41 -0300 Subject: [PATCH 03/24] ci: continue-on-error --- .github/workflows/ci_bench_levm_in_pr.yaml | 1 + .github/workflows/daily_reports.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/ci_bench_levm_in_pr.yaml b/.github/workflows/ci_bench_levm_in_pr.yaml index 74cac06e6b..1d5c2ac467 100644 --- a/.github/workflows/ci_bench_levm_in_pr.yaml +++ b/.github/workflows/ci_bench_levm_in_pr.yaml @@ -175,6 +175,7 @@ jobs: - name: Check EF-TESTS status is 100% id: check_tests + continue-on-error: true run: | cd crates/vm/levm if [ "$(awk '/Summary:/ {print $(NF)}' test_result.txt)" != "(100.00%)" ]; then diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index 09fd3d6a60..c64c0d8f1b 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -192,6 +192,7 @@ jobs: - name: Check EF-TESTS status is 100% id: check_tests + continue-on-error: true run: | cd crates/vm/levm if [ "$(awk '/**Summary**:/ {print $(NF)}' cmd/ef_tests/levm/levm_ef_tests_summary_github.txt)" != "(100.00%)" ]; then From e9c06833043b0b8ed73e00428bd74d18c8320c5f Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:14:09 -0300 Subject: [PATCH 04/24] test: ci --- crates/vm/levm/src/vm.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 85083c16f0..156d57e98c 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,9 +950,11 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { - delegation_bytes.into() - } else { + //delegation_bytes.into() Bytes::new() + } else { + //Bytes::new() + delegation_bytes.into() }; // 9. Increase the nonce of authority by one. From fe4071bb7d13b24b84626fbaa6aad5cff751ff26 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:21:58 -0300 Subject: [PATCH 05/24] feat: update comment only if it exists --- .github/workflows/ci_bench_levm_in_pr.yaml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci_bench_levm_in_pr.yaml b/.github/workflows/ci_bench_levm_in_pr.yaml index 1d5c2ac467..157efc63d1 100644 --- a/.github/workflows/ci_bench_levm_in_pr.yaml +++ b/.github/workflows/ci_bench_levm_in_pr.yaml @@ -202,8 +202,11 @@ jobs: comment-author: "github-actions[bot]" body-includes: "Summary:" + # If we have a failure, means that some ef-tests don't pass. + # If comment-id == '', means that we haven't created the comment. + # If both conditions are met, create the comment with the summary. - name: Create Comment - if: ${{ steps.check_tests.outcome == 'failure' && github.event_name == 'pull_request' }} + if: ${{ steps.check_tests.outcome == 'failure' && github.event_name == 'pull_request' && steps.fc.outputs.comment-id == '' }} uses: peter-evans/create-or-update-comment@v4 with: comment-id: ${{ steps.fc.outputs.comment-id }} @@ -211,3 +214,17 @@ jobs: issue-number: ${{ github.event.pull_request.number }} body-path: test_summary.txt edit-mode: replace + + # If we don't have a failure, means that all ef-tests pass. + # If comment-id != '', means that we've already created the comment. + # If both conditions are met, update the comment saying that all tests pass. + - name: Create Comment + if: ${{ steps.check_tests.outcome != 'failure' && github.event_name == 'pull_request' && steps.fc.outputs.comment-id != '' }} + uses: peter-evans/create-or-update-comment@v4 + with: + comment-id: ${{ steps.fc.outputs.comment-id }} + token: ${{ secrets.GITHUB_TOKEN }} + issue-number: ${{ github.event.pull_request.number }} + body: | + All EF-TESTS pass. + edit-mode: replace From f08828759605efe9502b6801b3d215acbbc58b2e Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:23:27 -0300 Subject: [PATCH 06/24] undo test change --- crates/vm/levm/src/vm.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 156d57e98c..85083c16f0 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,11 +950,9 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { - //delegation_bytes.into() - Bytes::new() - } else { - //Bytes::new() delegation_bytes.into() + } else { + Bytes::new() }; // 9. Increase the nonce of authority by one. From d6304f3d5924356745a71e5247e30b6af5e2b0bb Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:27:45 -0300 Subject: [PATCH 07/24] test with comment --- crates/vm/levm/src/vm.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 85083c16f0..ea567db27a 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,6 +950,7 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { + // test delegation_bytes.into() } else { Bytes::new() From 5567f74d62335e3a86bfbc69a6992035f2eabb9c Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:34:48 -0300 Subject: [PATCH 08/24] test --- crates/vm/levm/src/vm.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index ea567db27a..156d57e98c 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,10 +950,11 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { - // test - delegation_bytes.into() - } else { + //delegation_bytes.into() Bytes::new() + } else { + //Bytes::new() + delegation_bytes.into() }; // 9. Increase the nonce of authority by one. From 84ad4ca096208b80442293f296f925e495287fae Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:38:43 -0300 Subject: [PATCH 09/24] create or update on failure --- .github/workflows/ci_bench_levm_in_pr.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci_bench_levm_in_pr.yaml b/.github/workflows/ci_bench_levm_in_pr.yaml index 157efc63d1..276d8b8d24 100644 --- a/.github/workflows/ci_bench_levm_in_pr.yaml +++ b/.github/workflows/ci_bench_levm_in_pr.yaml @@ -203,10 +203,9 @@ jobs: body-includes: "Summary:" # If we have a failure, means that some ef-tests don't pass. - # If comment-id == '', means that we haven't created the comment. - # If both conditions are met, create the comment with the summary. + # If the condition is met, create or update the comment with the summary. - name: Create Comment - if: ${{ steps.check_tests.outcome == 'failure' && github.event_name == 'pull_request' && steps.fc.outputs.comment-id == '' }} + if: ${{ steps.check_tests.outcome == 'failure' && github.event_name == 'pull_request' }} uses: peter-evans/create-or-update-comment@v4 with: comment-id: ${{ steps.fc.outputs.comment-id }} @@ -218,7 +217,7 @@ jobs: # If we don't have a failure, means that all ef-tests pass. # If comment-id != '', means that we've already created the comment. # If both conditions are met, update the comment saying that all tests pass. - - name: Create Comment + - name: Update Comment -- ALL if: ${{ steps.check_tests.outcome != 'failure' && github.event_name == 'pull_request' && steps.fc.outputs.comment-id != '' }} uses: peter-evans/create-or-update-comment@v4 with: From c04e4f13644c4994089374fe5d9db698ab1140c2 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:49:53 -0300 Subject: [PATCH 10/24] test --- .github/workflows/ci_bench_levm_in_pr.yaml | 2 +- crates/vm/levm/src/vm.rs | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci_bench_levm_in_pr.yaml b/.github/workflows/ci_bench_levm_in_pr.yaml index 276d8b8d24..659ef933a1 100644 --- a/.github/workflows/ci_bench_levm_in_pr.yaml +++ b/.github/workflows/ci_bench_levm_in_pr.yaml @@ -225,5 +225,5 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} issue-number: ${{ github.event.pull_request.number }} body: | - All EF-TESTS pass. + Summary: All EF-TESTS pass. edit-mode: replace diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 156d57e98c..8d2653c0a8 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,10 +950,9 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { - //delegation_bytes.into() + //test Bytes::new() } else { - //Bytes::new() delegation_bytes.into() }; From 600d7a6f6d1994337f2d9addb4cb692c56ddf396 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 17:59:57 -0300 Subject: [PATCH 11/24] test --- crates/vm/levm/src/vm.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 8d2653c0a8..6186e17207 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -951,9 +951,9 @@ impl VM { auth_account.info.bytecode = if auth_tuple.address != Address::zero() { //test - Bytes::new() - } else { delegation_bytes.into() + } else { + Bytes::new() }; // 9. Increase the nonce of authority by one. From 10a6f9959d31cac66a013d5876cfba6853875bb4 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 18:09:57 -0300 Subject: [PATCH 12/24] test --- crates/vm/levm/src/vm.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 6186e17207..8d2653c0a8 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -951,9 +951,9 @@ impl VM { auth_account.info.bytecode = if auth_tuple.address != Address::zero() { //test - delegation_bytes.into() - } else { Bytes::new() + } else { + delegation_bytes.into() }; // 9. Increase the nonce of authority by one. From 30e3718543706d715025471c42bdcff4ffddc93e Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 18:19:28 -0300 Subject: [PATCH 13/24] undo test change --- crates/vm/levm/src/vm.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 8d2653c0a8..85083c16f0 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,10 +950,9 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { - //test - Bytes::new() - } else { delegation_bytes.into() + } else { + Bytes::new() }; // 9. Increase the nonce of authority by one. From 4abf742da32edb4d87511abbd47e6677f1101c08 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Wed, 29 Jan 2025 19:08:18 -0300 Subject: [PATCH 14/24] feat: hive diff msg only on change --- .github/scripts/publish_hive.sh | 2 +- .github/scripts/publish_levm_hive.sh | 2 +- .github/workflows/daily_reports.yaml | 63 +++++++++++++++++----------- 3 files changed, 40 insertions(+), 27 deletions(-) diff --git a/.github/scripts/publish_hive.sh b/.github/scripts/publish_hive.sh index 8b66671d6f..8db39565c5 100644 --- a/.github/scripts/publish_hive.sh +++ b/.github/scripts/publish_hive.sh @@ -1,7 +1,7 @@ curl -X POST $1 \ -H 'Content-Type: application/json; charset=utf-8' \ --data @- <> $GITHUB_STEP_SUMMARY cat results.md >> $GITHUB_STEP_SUMMARY - - name: Post results to Slack - env: - SLACK_WEBHOOKS: > - ${{ github.event_name == 'workflow_dispatch' - && secrets.TEST_CHANNEL_SLACK - || format( - '{0} {1} {2}', - secrets.ETHREX_L1_SLACK_WEBHOOK, - secrets.ETHREX_L2_SLACK_WEBHOOK, - secrets.LEVM_SLACK_WEBHOOK - ) - }} - SCRIPT: > - ${{ matrix.vm == 'levm' - && '.github/scripts/publish_levm_hive.sh' - || '.github/scripts/publish_hive.sh' - }} - run: | - for webhook in $SLACK_WEBHOOKS; do - sh $SCRIPT "$webhook" - done - hive-diff-report: name: Post tests diff to levm slack needs: hive-report @@ -148,7 +126,7 @@ jobs: - name: Rename result (2) run: cp results.md results_revm.md - - name: Post results diff to Slack + - name: Create diff message env: SLACK_WEBHOOK: > ${{ github.event_name == 'workflow_dispatch' @@ -158,7 +136,42 @@ jobs: run: | bash .github/scripts/levm_revm_diff.sh results_revm.md results_levm.md >> diff.md cat diff.md >> $GITHUB_STEP_SUMMARY - sh .github/scripts/publish_vms_diff.sh $SLACK_WEBHOOK + + - name: Post results to Slack + env: + SLACK_WEBHOOKS: > + ${{ github.event_name == 'workflow_dispatch' + && secrets.TEST_CHANNEL_SLACK + || format( + '{0} {1} {2}', + secrets.ETHREX_L1_SLACK_WEBHOOK, + secrets.ETHREX_L2_SLACK_WEBHOOK, + secrets.LEVM_SLACK_WEBHOOK + ) + }} + run: | + for webhook in $SLACK_WEBHOOKS; do + sh .github/scripts/publish_levm_hive.sh "$webhook" + sh .github/scripts/publish_hive.sh "$webhook" + done + echo "Sending Results" >> $GITHUB_STEP_SUMMARY + + - name: Post results diff to Slack + env: + SLACK_WEBHOOK: > + ${{ github.event_name == 'workflow_dispatch' + && secrets.TEST_CHANNEL_SLACK + || secrets.LEVM_SLACK_WEBHOOK + }} + # Only send diff message if the diff has changed + run: | + DIFF_CONTENT=$(cat diff.md) + if [ "$DIFF_CONTENT" == "No differences found" ]; then + echo "No differences to post" >> $GITHUB_STEP_SUMMARY + else + sh .github/scripts/publish_vms_diff.sh $SLACK_WEBHOOK + echo "Sending Results" >> $GITHUB_STEP_SUMMARY + fi levm-test: name: Generate Report for LEVM EF Tests From bc72374a4f257629e682d1d4600396495fb8a2bc Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 09:43:30 -0300 Subject: [PATCH 15/24] feat: hive test in ci_levm --- .github/workflows/ci_levm.yaml | 46 +++++++++- .github/workflows/common_hive_reports.yaml | 96 ++++++++++++++++++++ .github/workflows/daily_reports.yaml | 101 +-------------------- 3 files changed, 143 insertions(+), 100 deletions(-) create mode 100644 .github/workflows/common_hive_reports.yaml diff --git a/.github/workflows/ci_levm.yaml b/.github/workflows/ci_levm.yaml index 75ae87a9b5..29416fd810 100644 --- a/.github/workflows/ci_levm.yaml +++ b/.github/workflows/ci_levm.yaml @@ -2,9 +2,9 @@ name: LEVM on: push: - branches: [ "main" ] + branches: ["main"] pull_request: - branches: [ "**" ] + branches: ["**"] paths: - "crates/vm/levm/**" @@ -58,6 +58,48 @@ jobs: echo "Percentage is not 100%." exit 1 fi + + hive-report-creation: + uses: ./.github/workflows/common_hive_reports.yaml + # Check we don't have a regression + hive-test-check: + # "Integration Test" is a required check, don't change the name + name: Integration Test + needs: hive-report-creation + runs-on: ubuntu-latest + steps: + - name: Checkout sources + uses: actions/checkout@v4 + + - name: Download results (levm) + uses: actions/download-artifact@v4 + with: + name: results_levm.md + + - name: Rename result (1) + run: cp results.md results_levm.md + + - name: Download results (revm) + uses: actions/download-artifact@v4 + with: + name: results_revm.md + + - name: Rename result (2) + run: cp results.md results_revm.md + + - name: Create diff message + run: | + bash .github/scripts/levm_revm_diff.sh results_revm.md results_levm.md >> diff.md + cat diff.md >> $GITHUB_STEP_SUMMARY + + - name: Check Regression + run: | + DIFF_CONTENT=$(cat diff.md) + if [ "$DIFF_CONTENT" != "No differences found" ]; then + echo "Regression found." + exit 1; + fi + test: # "Test" is a required check, don't change the name name: Test diff --git a/.github/workflows/common_hive_reports.yaml b/.github/workflows/common_hive_reports.yaml new file mode 100644 index 0000000000..53e5c4cd39 --- /dev/null +++ b/.github/workflows/common_hive_reports.yaml @@ -0,0 +1,96 @@ +name: Run Hive Tests + +on: workflow_call + +jobs: + run-hive: + name: Hive (${{ matrix.vm }}) - ${{ matrix.test.name }} + runs-on: ubuntu-latest + strategy: + matrix: + vm: [levm, revm] + test: + - { + name: "Rpc Compat tests", + file_name: rpc-compat, + simulation: ethereum/rpc-compat, + } + - { name: "Devp2p eth tests", file_name: devp2p, simulation: devp2p } + - { + name: "Cancun Engine tests", + file_name: engine, + simulation: ethereum/engine, + } + - { name: "Sync tests", file_name: sync, simulation: ethereum/sync } + + steps: + - name: Pull image + if: ${{ matrix.vm == 'revm' }} + run: | + docker pull ghcr.io/lambdaclass/ethrex:latest + docker tag ghcr.io/lambdaclass/ethrex:latest ethrex:latest + + - name: Checkout sources + uses: actions/checkout@v4 + + - name: Build Image with LEVM + if: ${{ matrix.vm == 'levm' }} + run: cd crates/vm/levm && make build-image-levm + + - name: Setup Go + uses: actions/setup-go@v5 + + - name: Setup Hive + run: make setup-hive + + - name: Run Hive Simulation + run: cd hive && ./hive --client ethrex --sim ${{ matrix.test.simulation }} --sim.parallelism 16 + continue-on-error: true + + - name: Upload results + uses: actions/upload-artifact@v4 + with: + name: ${{ matrix.test.file_name }}_${{ matrix.vm }}_logs + path: hive/workspace/logs/*-*.json + if-no-files-found: error + + hive-report: + name: Generate and Save report (${{ matrix.vm }}) + needs: run-hive + runs-on: ubuntu-latest + strategy: + matrix: + vm: [levm, revm] + steps: + - name: Checkout sources + uses: actions/checkout@v4 + + - name: Rustup toolchain install + uses: dtolnay/rust-toolchain@stable + with: + toolchain: ${{ env.RUST_VERSION }} + + - name: Download all results + uses: actions/download-artifact@v4 + with: + path: hive/workspace/logs + pattern: "*_${{ matrix.vm }}_logs" + merge-multiple: true + + - name: Caching + uses: Swatinem/rust-cache@v2 + + - name: Generate the hive report + run: cargo run -p hive_report > results.md + + - name: Upload ${{matrix.vm}} result + uses: actions/upload-artifact@v4 + with: + name: results_${{matrix.vm}}.md + path: results.md + if-no-files-found: error + + - name: Post results in summary + run: | + echo "# Hive coverage report (${{ matrix.vm }})" >> $GITHUB_STEP_SUMMARY + cat results.md >> $GITHUB_STEP_SUMMARY diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index 84066ab351..a31c66cb4c 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -10,101 +10,12 @@ env: RUST_VERSION: 1.81.0 jobs: - run-hive: - name: Hive (${{ matrix.vm }}) - ${{ matrix.test.name }} - runs-on: ubuntu-latest - strategy: - matrix: - vm: [levm, revm] - test: - - { - name: "Rpc Compat tests", - file_name: rpc-compat, - simulation: ethereum/rpc-compat, - } - - { name: "Devp2p eth tests", file_name: devp2p, simulation: devp2p } - - { - name: "Cancun Engine tests", - file_name: engine, - simulation: ethereum/engine, - } - - { name: "Sync tests", file_name: sync, simulation: ethereum/sync } - - steps: - - name: Pull image - if: ${{ matrix.vm == 'revm' }} - run: | - docker pull ghcr.io/lambdaclass/ethrex:latest - docker tag ghcr.io/lambdaclass/ethrex:latest ethrex:latest - - - name: Checkout sources - uses: actions/checkout@v4 - - - name: Build Image with LEVM - if: ${{ matrix.vm == 'levm' }} - run: cd crates/vm/levm && make build-image-levm - - - name: Setup Go - uses: actions/setup-go@v5 - - - name: Setup Hive - run: make setup-hive - - - name: Run Hive Simulation - run: cd hive && ./hive --client ethrex --sim ${{ matrix.test.simulation }} --sim.parallelism 16 - continue-on-error: true - - - name: Upload results - uses: actions/upload-artifact@v4 - with: - name: ${{ matrix.test.file_name }}_${{ matrix.vm }}_logs - path: hive/workspace/logs/*-*.json - if-no-files-found: error - - hive-report: - name: Generate and Save report (${{ matrix.vm }}) - needs: run-hive - runs-on: ubuntu-latest - strategy: - matrix: - vm: [levm, revm] - steps: - - name: Checkout sources - uses: actions/checkout@v4 - - - name: Rustup toolchain install - uses: dtolnay/rust-toolchain@stable - with: - toolchain: ${{ env.RUST_VERSION }} - - - name: Download all results - uses: actions/download-artifact@v4 - with: - path: hive/workspace/logs - pattern: "*_${{ matrix.vm }}_logs" - merge-multiple: true - - - name: Caching - uses: Swatinem/rust-cache@v2 - - - name: Generate the hive report - run: cargo run -p hive_report > results.md - - - name: Upload ${{matrix.vm}} result - uses: actions/upload-artifact@v4 - with: - name: results_${{matrix.vm}}.md - path: results.md - if-no-files-found: error - - - name: Post results in summary - run: | - echo "# Hive coverage report (${{ matrix.vm }})" >> $GITHUB_STEP_SUMMARY - cat results.md >> $GITHUB_STEP_SUMMARY + hive-report-creation: + uses: ./.github/workflows/common_hive_reports.yaml hive-diff-report: name: Post tests diff to levm slack - needs: hive-report + needs: hive-report-creation runs-on: ubuntu-latest steps: - name: Checkout sources @@ -127,12 +38,6 @@ jobs: run: cp results.md results_revm.md - name: Create diff message - env: - SLACK_WEBHOOK: > - ${{ github.event_name == 'workflow_dispatch' - && secrets.TEST_CHANNEL_SLACK - || secrets.LEVM_SLACK_WEBHOOK - }} run: | bash .github/scripts/levm_revm_diff.sh results_revm.md results_levm.md >> diff.md cat diff.md >> $GITHUB_STEP_SUMMARY From e81dc4e78e416325c3be41478087d35c52300f5a Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 09:46:04 -0300 Subject: [PATCH 16/24] test --- crates/vm/levm/src/vm.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 85083c16f0..6186e17207 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,6 +950,7 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { + //test delegation_bytes.into() } else { Bytes::new() From 9429b116fe8432a37ebea5279bae71e25de4c627 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 10:13:30 -0300 Subject: [PATCH 17/24] fix: RUST version --- .github/workflows/common_hive_reports.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/common_hive_reports.yaml b/.github/workflows/common_hive_reports.yaml index 53e5c4cd39..3c370b73ed 100644 --- a/.github/workflows/common_hive_reports.yaml +++ b/.github/workflows/common_hive_reports.yaml @@ -2,6 +2,10 @@ name: Run Hive Tests on: workflow_call +env: + CARGO_TERM_COLOR: always + RUST_VERSION: 1.81.0 + jobs: run-hive: name: Hive (${{ matrix.vm }}) - ${{ matrix.test.name }} From b7890a069199ffbaf260ee04fb6302f6723361f7 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 10:48:11 -0300 Subject: [PATCH 18/24] fix: report Check --- .github/workflows/ci_levm.yaml | 5 +++-- .github/workflows/daily_reports.yaml | 3 +-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci_levm.yaml b/.github/workflows/ci_levm.yaml index 29416fd810..4b53248ff2 100644 --- a/.github/workflows/ci_levm.yaml +++ b/.github/workflows/ci_levm.yaml @@ -94,8 +94,9 @@ jobs: - name: Check Regression run: | - DIFF_CONTENT=$(cat diff.md) - if [ "$DIFF_CONTENT" != "No differences found" ]; then + if grep -q "No differences found" diff.md; then + echo "No regression found." + else echo "Regression found." exit 1; fi diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index a31c66cb4c..1da895e562 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -70,8 +70,7 @@ jobs: }} # Only send diff message if the diff has changed run: | - DIFF_CONTENT=$(cat diff.md) - if [ "$DIFF_CONTENT" == "No differences found" ]; then + if grep -q "No differences found" diff.md; then echo "No differences to post" >> $GITHUB_STEP_SUMMARY else sh .github/scripts/publish_vms_diff.sh $SLACK_WEBHOOK From 3a186fe83d614bb22ded2f197d71a961964d57d5 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 11:20:29 -0300 Subject: [PATCH 19/24] undo test msg --- crates/vm/levm/src/vm.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 6186e17207..85083c16f0 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -950,7 +950,6 @@ impl VM { }; auth_account.info.bytecode = if auth_tuple.address != Address::zero() { - //test delegation_bytes.into() } else { Bytes::new() From 5f3a652970d34ab72f7637cdc5866e5a106ac2c8 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 15:11:17 -0300 Subject: [PATCH 20/24] pr_comments: single Integration Test --- .github/workflows/ci_levm.yaml | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci_levm.yaml b/.github/workflows/ci_levm.yaml index 4b53248ff2..a90a9fc67b 100644 --- a/.github/workflows/ci_levm.yaml +++ b/.github/workflows/ci_levm.yaml @@ -18,8 +18,7 @@ env: jobs: ef-test: - # "Integration Test" is a required check, don't change the name - name: Integration Test + name: EF Tests Check runs-on: ubuntu-latest steps: - name: Checkout sources @@ -62,9 +61,9 @@ jobs: hive-report-creation: uses: ./.github/workflows/common_hive_reports.yaml # Check we don't have a regression - hive-test-check: + hive-test: # "Integration Test" is a required check, don't change the name - name: Integration Test + name: Hive Tests Check needs: hive-report-creation runs-on: ubuntu-latest steps: @@ -101,6 +100,27 @@ jobs: exit 1; fi + # The purpose of this job is to add it as a required check in GitHub so that we don't have to add every individual job as a required check + all-tests: + # "Integration Test" is a required check, don't change the name + name: Integration Test + runs-on: ubuntu-latest + needs: [hive-test, ef-test] + # Make sure this job runs even if the previous jobs failed or were skipped + if: ${{ always() && needs.hive-test.result != 'skipped' && needs.ef-test.result != 'skipped' }} + steps: + - name: Check if any job failed + run: | + if [ "${{ needs.hive-test.result }}" != "success" ]; then + echo "Job Hive Tests Check failed" + exit 1 + fi + + if [ "${{ needs.ef-test.result }}" != "success" ]; then + echo "Job EF Tests Check failed" + exit 1 + fi + test: # "Test" is a required check, don't change the name name: Test From 054089ef7629ab82911c35521d7b1d5cf7f65a9f Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 15:14:58 -0300 Subject: [PATCH 21/24] pr_comments: common_hive_reports.yaml -> common/hive_reports.yaml --- .github/workflows/ci_levm.yaml | 2 +- .../{common_hive_reports.yaml => common/hive_reports.yaml} | 0 .github/workflows/daily_reports.yaml | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename .github/workflows/{common_hive_reports.yaml => common/hive_reports.yaml} (100%) diff --git a/.github/workflows/ci_levm.yaml b/.github/workflows/ci_levm.yaml index a90a9fc67b..3c49245892 100644 --- a/.github/workflows/ci_levm.yaml +++ b/.github/workflows/ci_levm.yaml @@ -59,7 +59,7 @@ jobs: fi hive-report-creation: - uses: ./.github/workflows/common_hive_reports.yaml + uses: ./.github/workflows/common/hive_reports.yaml # Check we don't have a regression hive-test: # "Integration Test" is a required check, don't change the name diff --git a/.github/workflows/common_hive_reports.yaml b/.github/workflows/common/hive_reports.yaml similarity index 100% rename from .github/workflows/common_hive_reports.yaml rename to .github/workflows/common/hive_reports.yaml diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index 1da895e562..134013da98 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -11,7 +11,7 @@ env: jobs: hive-report-creation: - uses: ./.github/workflows/common_hive_reports.yaml + uses: ./.github/workflows/common/hive_reports.yaml hive-diff-report: name: Post tests diff to levm slack From e91040b6efdc97305a22585f071e5f410c03d766 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 16:35:36 -0300 Subject: [PATCH 22/24] pr_comments: include inputs, compare against main --- ...vm_revm_diff.sh => hive_levm_revm_diff.sh} | 0 .github/workflows/ci_levm.yaml | 27 ++++++++------ .github/workflows/common/hive_reports.yaml | 36 +++++++++++-------- .github/workflows/daily_reports.yaml | 18 +++++++--- 4 files changed, 52 insertions(+), 29 deletions(-) rename .github/scripts/{levm_revm_diff.sh => hive_levm_revm_diff.sh} (100%) diff --git a/.github/scripts/levm_revm_diff.sh b/.github/scripts/hive_levm_revm_diff.sh similarity index 100% rename from .github/scripts/levm_revm_diff.sh rename to .github/scripts/hive_levm_revm_diff.sh diff --git a/.github/workflows/ci_levm.yaml b/.github/workflows/ci_levm.yaml index 3c49245892..a7ffb12b27 100644 --- a/.github/workflows/ci_levm.yaml +++ b/.github/workflows/ci_levm.yaml @@ -60,9 +60,12 @@ jobs: hive-report-creation: uses: ./.github/workflows/common/hive_reports.yaml - # Check we don't have a regression + with: + evm: "levm" + job_type: "trigger" + + # Check we don't have a regression against main hive-test: - # "Integration Test" is a required check, don't change the name name: Hive Tests Check needs: hive-report-creation runs-on: ubuntu-latest @@ -70,34 +73,38 @@ jobs: - name: Checkout sources uses: actions/checkout@v4 - - name: Download results (levm) + - name: Download results (pr) uses: actions/download-artifact@v4 with: - name: results_levm.md + name: results_levm_trigger.md - name: Rename result (1) run: cp results.md results_levm.md - - name: Download results (revm) + - name: Download results (main) uses: actions/download-artifact@v4 with: - name: results_revm.md + name: results_levm_daily.md + # If we don't have the file it will use the result(1) file + continue-on-error: true - name: Rename result (2) - run: cp results.md results_revm.md + run: cp results.md results_levm_daily.md - name: Create diff message run: | - bash .github/scripts/levm_revm_diff.sh results_revm.md results_levm.md >> diff.md + bash .github/scripts/hive_levm_revm_diff.sh results_levm_daily.md results_levm.md >> diff.md cat diff.md >> $GITHUB_STEP_SUMMARY - name: Check Regression run: | if grep -q "No differences found" diff.md; then echo "No regression found." + elif ! grep -q "regression" diff.md; then + echo "No regression found." else - echo "Regression found." - exit 1; + echo "Differences found." + exit 1 fi # The purpose of this job is to add it as a required check in GitHub so that we don't have to add every individual job as a required check diff --git a/.github/workflows/common/hive_reports.yaml b/.github/workflows/common/hive_reports.yaml index 3c370b73ed..2f11bb5d90 100644 --- a/.github/workflows/common/hive_reports.yaml +++ b/.github/workflows/common/hive_reports.yaml @@ -1,6 +1,17 @@ name: Run Hive Tests -on: workflow_call +on: + workflow_call: + inputs: + # Must be 'levm' or 'revm' + evm: + required: true + type: string + # Must be 'daily' or 'trigger' + # If it's daily, it is assumed that the CI is checking out the main branch + job_type: + required: true + type: string env: CARGO_TERM_COLOR: always @@ -8,11 +19,10 @@ env: jobs: run-hive: - name: Hive (${{ matrix.vm }}) - ${{ matrix.test.name }} + name: Hive (${{ inputs.evm }}) - ${{ matrix.test.name }} runs-on: ubuntu-latest strategy: matrix: - vm: [levm, revm] test: - { name: "Rpc Compat tests", @@ -29,7 +39,7 @@ jobs: steps: - name: Pull image - if: ${{ matrix.vm == 'revm' }} + if: ${{ inputs.evm == 'revm' }} run: | docker pull ghcr.io/lambdaclass/ethrex:latest docker tag ghcr.io/lambdaclass/ethrex:latest ethrex:latest @@ -38,7 +48,7 @@ jobs: uses: actions/checkout@v4 - name: Build Image with LEVM - if: ${{ matrix.vm == 'levm' }} + if: ${{ inputs.evm == 'levm' }} run: cd crates/vm/levm && make build-image-levm - name: Setup Go @@ -54,17 +64,14 @@ jobs: - name: Upload results uses: actions/upload-artifact@v4 with: - name: ${{ matrix.test.file_name }}_${{ matrix.vm }}_logs + name: ${{ matrix.test.file_name }}_${{ inputs.evm }}_${{ inputs.job_type }}_logs path: hive/workspace/logs/*-*.json if-no-files-found: error hive-report: - name: Generate and Save report (${{ matrix.vm }}) + name: Generate and Save report (${{ inputs.evm }}) needs: run-hive runs-on: ubuntu-latest - strategy: - matrix: - vm: [levm, revm] steps: - name: Checkout sources uses: actions/checkout@v4 @@ -78,7 +85,7 @@ jobs: uses: actions/download-artifact@v4 with: path: hive/workspace/logs - pattern: "*_${{ matrix.vm }}_logs" + pattern: "*_${{ inputs.evm }}_${{ inputs.job_type }}_logs" merge-multiple: true - name: Caching @@ -87,14 +94,15 @@ jobs: - name: Generate the hive report run: cargo run -p hive_report > results.md - - name: Upload ${{matrix.vm}} result + - name: Upload ${{inputs.evm}}_${{ inputs.job_type }} result + if: ${{ inputs.main_branch != 'true' }} uses: actions/upload-artifact@v4 with: - name: results_${{matrix.vm}}.md + name: results_${{inputs.evm}}_${{ inputs.job_type }}.md path: results.md if-no-files-found: error - name: Post results in summary run: | - echo "# Hive coverage report (${{ matrix.vm }})" >> $GITHUB_STEP_SUMMARY + echo "# Hive coverage report (${{ inputs.evm }})" >> $GITHUB_STEP_SUMMARY cat results.md >> $GITHUB_STEP_SUMMARY diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index 134013da98..ca5a2fb8be 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -10,12 +10,20 @@ env: RUST_VERSION: 1.81.0 jobs: - hive-report-creation: + hive-report-creation-levm: uses: ./.github/workflows/common/hive_reports.yaml + with: + evm: "levm" + job_type: "daily" + hive-report-creation-revm: + uses: ./.github/workflows/common/hive_reports.yaml + with: + evm: "revm" + job_type: "daily" hive-diff-report: name: Post tests diff to levm slack - needs: hive-report-creation + needs: [hive-report-creation-levm, hive-report-creation-revm] runs-on: ubuntu-latest steps: - name: Checkout sources @@ -24,7 +32,7 @@ jobs: - name: Download results (levm) uses: actions/download-artifact@v4 with: - name: results_levm.md + name: results_levm_daily_main.md - name: Rename result (1) run: cp results.md results_levm.md @@ -32,14 +40,14 @@ jobs: - name: Download results (revm) uses: actions/download-artifact@v4 with: - name: results_revm.md + name: results_revm_daily_main.md - name: Rename result (2) run: cp results.md results_revm.md - name: Create diff message run: | - bash .github/scripts/levm_revm_diff.sh results_revm.md results_levm.md >> diff.md + bash .github/scripts/hive_levm_revm_diff.sh results_revm.md results_levm.md >> diff.md cat diff.md >> $GITHUB_STEP_SUMMARY - name: Post results to Slack From 9265938568972027ce2f8925ca22731a807e23d3 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 16:36:09 -0300 Subject: [PATCH 23/24] rm common folder --- .github/workflows/ci_levm.yaml | 8 +++++--- .../hive_reports.yaml => common_hive_reports.yaml} | 1 - .github/workflows/daily_reports.yaml | 8 ++++---- crates/vm/levm/src/vm.rs | 1 + 4 files changed, 10 insertions(+), 8 deletions(-) rename .github/workflows/{common/hive_reports.yaml => common_hive_reports.yaml} (98%) diff --git a/.github/workflows/ci_levm.yaml b/.github/workflows/ci_levm.yaml index a7ffb12b27..9bd213bf77 100644 --- a/.github/workflows/ci_levm.yaml +++ b/.github/workflows/ci_levm.yaml @@ -18,6 +18,7 @@ env: jobs: ef-test: + if: ${{ github.event_name != 'merge_group' }} name: EF Tests Check runs-on: ubuntu-latest steps: @@ -59,13 +60,14 @@ jobs: fi hive-report-creation: - uses: ./.github/workflows/common/hive_reports.yaml + uses: ./.github/workflows/common_hive_reports.yaml with: - evm: "levm" - job_type: "trigger" + evm: levm + job_type: trigger # Check we don't have a regression against main hive-test: + if: ${{ github.event_name != 'merge_group' }} name: Hive Tests Check needs: hive-report-creation runs-on: ubuntu-latest diff --git a/.github/workflows/common/hive_reports.yaml b/.github/workflows/common_hive_reports.yaml similarity index 98% rename from .github/workflows/common/hive_reports.yaml rename to .github/workflows/common_hive_reports.yaml index 2f11bb5d90..fc789402cc 100644 --- a/.github/workflows/common/hive_reports.yaml +++ b/.github/workflows/common_hive_reports.yaml @@ -95,7 +95,6 @@ jobs: run: cargo run -p hive_report > results.md - name: Upload ${{inputs.evm}}_${{ inputs.job_type }} result - if: ${{ inputs.main_branch != 'true' }} uses: actions/upload-artifact@v4 with: name: results_${{inputs.evm}}_${{ inputs.job_type }}.md diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index ca5a2fb8be..5fff3f4c7f 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -13,13 +13,13 @@ jobs: hive-report-creation-levm: uses: ./.github/workflows/common/hive_reports.yaml with: - evm: "levm" - job_type: "daily" + evm: levm + job_type: daily hive-report-creation-revm: uses: ./.github/workflows/common/hive_reports.yaml with: - evm: "revm" - job_type: "daily" + evm: revm + job_type: daily hive-diff-report: name: Post tests diff to levm slack diff --git a/crates/vm/levm/src/vm.rs b/crates/vm/levm/src/vm.rs index 85083c16f0..82f74fbf85 100644 --- a/crates/vm/levm/src/vm.rs +++ b/crates/vm/levm/src/vm.rs @@ -949,6 +949,7 @@ impl VM { } }; + // TESTING LEVM CI auth_account.info.bytecode = if auth_tuple.address != Address::zero() { delegation_bytes.into() } else { From 149f5492d098975acd52df382bacc803204b38d0 Mon Sep 17 00:00:00 2001 From: fborello-lambda Date: Thu, 30 Jan 2025 18:34:11 -0300 Subject: [PATCH 24/24] fix --- .github/workflows/ci_levm.yaml | 2 +- .github/workflows/daily_reports.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci_levm.yaml b/.github/workflows/ci_levm.yaml index 9bd213bf77..46f76313e8 100644 --- a/.github/workflows/ci_levm.yaml +++ b/.github/workflows/ci_levm.yaml @@ -101,7 +101,7 @@ jobs: - name: Check Regression run: | if grep -q "No differences found" diff.md; then - echo "No regression found." + echo "No differences found." elif ! grep -q "regression" diff.md; then echo "No regression found." else diff --git a/.github/workflows/daily_reports.yaml b/.github/workflows/daily_reports.yaml index 5fff3f4c7f..a01eb690fb 100644 --- a/.github/workflows/daily_reports.yaml +++ b/.github/workflows/daily_reports.yaml @@ -11,12 +11,12 @@ env: jobs: hive-report-creation-levm: - uses: ./.github/workflows/common/hive_reports.yaml + uses: ./.github/workflows/common_hive_reports.yaml with: evm: levm job_type: daily hive-report-creation-revm: - uses: ./.github/workflows/common/hive_reports.yaml + uses: ./.github/workflows/common_hive_reports.yaml with: evm: revm job_type: daily