Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support kdf paths on Keystore #1030

Open
Tracked by #1110
MegaRedHand opened this issue Apr 23, 2024 · 6 comments
Open
Tracked by #1110

Support kdf paths on Keystore #1030

MegaRedHand opened this issue Apr 23, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@MegaRedHand
Copy link
Collaborator

MegaRedHand commented Apr 23, 2024 •
edited
Loading

Context: #1013

ERC-2335 keystores have a path field with a EIP-2333 path for deriving the secret. We should support non-empty values of that field.
@MegaRedHand MegaRedHand added the good first issue Good for newcomers label Apr 23, 2024
@afsanehForsat

This comment was marked as abuse.

Sign in to view
@artemd24
Copy link
Contributor

I'd like to tackle this!

@MegaRedHand
Copy link
Collaborator Author

Sure! Go ahead!

@MegaRedHand MegaRedHand moved this from Ready to In progress in Lambda Ethereum Consensus Node May 23, 2024
@artemd24
Copy link
Contributor

Hello @MegaRedHand!
I have started this issue, but it's a bit unclear for me, so I have a question about implementation.
Should I make password parameter in decode_str! optional and in case of nil get "secret" from decoded_json["path"] file?

@MegaRedHand
Copy link
Collaborator Author

No. The path attribute is for deriving the secret key. I'm not sure how it works, but once the secret is retrieved you should be able to use secret + path to derive a secret key. There is more info in the EIP linked in the issue.

@Arkenan Arkenan moved this from In progress to Backlog in Lambda Ethereum Consensus Node Jul 1, 2024
@Arkenan
Copy link
Collaborator

Arkenan commented Jul 9, 2024

Unassigned (more than 1 month of inactivity)

@avilagaston9 avilagaston9 mentioned this issue Aug 9, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Lambda Ethereum Consensus Node
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Arkenan @artemd24 @MegaRedHand @afsanehForsat