Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional checks without specific PHP version uses invalid PHP version #319

Open
boesing opened this issue Sep 26, 2024 · 1 comment
Open
Labels
Bug Something isn't working

Comments

@boesing
Copy link
Member

boesing commented Sep 26, 2024

Bug Report

Q A
Version(s) latest

Summary

When providing additional_checks without a specific PHP version, the "stable PHP version" is being used.
That "stable PHP version" could be out of range of the actual project.

Current behavior

PHP 8.1 is used for an additional_checks job without an option in a project with minimum PHP 8.2 requirement.

{
    "name": "Linting [8.1, locked]",
    "operatingSystem": "ubuntu-latest",
    "action": "laminas/laminas-continuous-integration-action@v1",
    "job": {
      "command": "vendor/bin/php-parallel-lint --exclude .git/ --exclude vendor/ --no-progress .",
      "php": "8.1",
      "extensions": [],
      "ini": [],
      "dependencies": "locked",
      "ignore_platform_reqs_8": false,
      "ignore_php_platform_requirement": false,
      "additional_composer_arguments": []
    }
  }

How to reproduce

{
    "extensions": ["mysql"],
    "additional_checks": [
        {
            "name": "Linting",
            "job": {
                "command": "vendor/bin/php-parallel-lint --exclude .git/ --exclude vendor/ --no-progress .",
                "dependencies": "locked"
            }
        }
    ]
}
{
    "name": "example/example",
    "description": "Example project",
    "license": "proprietary",
    "type": "project",
    "require": {
        "php": "~8.2.0"
    },
    "require-dev": {
        "php-parallel-lint/php-parallel-lint": "^1.4"
    }
}

Expected behavior

Parallel lint is properly executed with the minimum supported PHP version of the project.

@boesing boesing added the Bug Something isn't working label Sep 26, 2024
@boesing
Copy link
Member Author

boesing commented Sep 26, 2024

Temporary fix is providing a value in php property within the additional check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant