Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CSS Markup #19

Open
weierophinney opened this issue Dec 31, 2019 · 4 comments
Open

Feature: CSS Markup #19

weierophinney opened this issue Dec 31, 2019 · 4 comments

Comments

@weierophinney
Copy link
Member

Would it be possible to add all the CSS Markup into a CSS File so that when you view the source in a browser you don't have to scroll to find your code?

Right now I have to scroll past all the ZDT CSS Markup in the source to look at my own source and it can be quite annoying at times.


Originally posted by @diemuzi at zendframework/zend-developer-tools#118

@weierophinney
Copy link
Member Author

@diemuzi the idea is to make everything in a single HTTP request. That's the good/bad part of the toolbar.


Originally posted by @Ocramius at zendframework/zend-developer-tools#118 (comment)

@weierophinney
Copy link
Member Author

Hrmm... Perhaps a flag that we can set to either make it a single request or file based?

OR

Perhaps the CSS can be loaded at the end of the page? That would be fine too actually =)


Originally posted by @diemuzi at zendframework/zend-developer-tools#118 (comment)

@weierophinney
Copy link
Member Author

@diemuzi using a custom CSS placeholder that collects all of the CSS from the various toolbar components would be fine.


Originally posted by @Ocramius at zendframework/zend-developer-tools#118 (comment)

@weierophinney
Copy link
Member Author

move style to body:
(http://stackoverflow.com/questions/2830296/using-style-tags-in-the-body-with-other-html)

view/zend-developer-tools/toolbar/style.phtml, Line 2:
< style type="text/css" media="screen" scoped>

src/ZendDeveloperTools/Listener/ToolbarListener.php, Lines 161-162:
$injected = preg_replace('/</body>/i', $style . $toolbar . "\n< / body>", $response->getBody(), 1);
//$injected = preg_replace('/</head>/i', $style . "\n", $injected, 1);


Originally posted by @oliverkoenig at zendframework/zend-developer-tools#118 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant