-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To-do list #20
Comments
I am gonna place the same header to all input files, would something like that work for you ?
To increase consistency, I think it would be best to have a systematic naming system for fix. Currently it alternates between
What would be the best system? I think that having a name that truly reflect the purpose of the fix would be better, but its difficult to do without making it very long, which is not great given the width constraints of the pdf semi-column. |
I don't think there is one. Traditionally, those IDs are numbers (this may be inherited from when LAMMPS was written in Fortran), but those can be confusing unless one always uses the same number for the same kind of fix. It is tempting to make them similar or even identical to the fix style, but I think that can be confusing, too. I've seen enough of those posted to MatSci.org and often have trouble telling which is which. One possible way to avoid confusion is to make (some?) IDs uppercase. For groups, for example, that doesn't work so well and a single word (or an abbreviated word, or the word without vowels or similar) might be better. Similar for regions and both of those are then better in lowercase. I suggest you experiment a bit. This could be a case of "you know it when you do it", and you may end up using something else. |
Just noticed https://github.com/lammpstutorials/lammpstutorials-avatars/ |
In every folder, I added a file called "avatar.png" which has a transparent background and should in principe look good with both dark and light themes. If its simpler for you, there is also an avatar-dark.png and an avatar-light.png files without tranparent backgrounds. |
These comments must not be at the very beginning of any data file. This will result that the data file title, e.g.:
Is not going to be ignored as needed and triggering errors. The title also contains metadata (like "CGCMM") that tells (some) third-party tools about the expected conventions with additional comments containing information that LAMMPS does not use, but the tools. |
@simongravelle I am currently building new LAMMPS-GUI test packages for Linux. |
Noted, I will remove it from data file. |
Great I will use it tomorrow as I test all the remaining tutorials. |
No need to remove, just put the title back in the first line.
…On Fri, Dec 27, 2024, 16:56 Simon Gravelle ***@***.***> wrote:
These comments must *not* be at the very beginning of any data file
Noted, I will remove it from data file.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACGTY342IWOTA2GS33M6DL2HXEJXAVCNFSM6AAAAABMB6ZSYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGA2TKOJXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Add a tutorial 8 (@jrgissing, @simongravelle)
Before submitting:
create and verify that LAMMPS-GUI has working wizards to set up all tutorials
make sure the LAMMPS scripts in the scripts/ folder are consistent with the tex:
make sure all graphs are generated from the last versions of the inputs
make sure all links inside the PDF and links to external websites are correctly formatted and link to the correct target
make indentation of paragraphs consistent and insert/remove
\noindent
macros as neededtest all inputs in the scripts/ folder with the 2024 stable release of LAMMPS
give the same header to all the file shared in the files/ folder, indicating the license, author, and DOI of the publication
homogeneize the fix and variable name (right now there is a mix of fix mynvt, fix nvt1, fix 1)
Suggestions:
In tutorial 6, there is a computationally expensive first step where a block of silica is created. Remove and provide directly the equilibrated amorphous silica. SG: I choose to keep it but to reduce the duration of the temperature ramps.
When copy-pasting the folder names from the pdf, it does not work well and funny caracters are getting copied. Use verbatim for folder names as well?
AK: this should become mostly a non-issue with adding the tutorial setup wizards in LAMMPS-GUI. But it may nevertheless worth looking into for those who are not using the GUI.
In tutorial 2 (breakable bonds), could we use a shorter run? Done.
The text was updated successfully, but these errors were encountered: