Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessarily strict httpx dependency #724

Open
artdent opened this issue Feb 3, 2025 · 1 comment
Open

Unnecessarily strict httpx dependency #724

artdent opened this issue Feb 3, 2025 · 1 comment
Labels
investigate

Comments

@artdent
Copy link

artdent commented Feb 3, 2025

PR #674 upgraded the minimum version of httpx from 0.27.0 to 0.28.0. This has annoying downstream effects, such as requiring consumers of this package to upgrade to newer versions of libraries like starlette and fastapi. In the PR, it's not clear that a newer version of httpx was needed for any particular reason related to the functionality of langchain-google. Could this sort of change be avoided in the future?
@langcarl langcarl bot added the investigate label Feb 3, 2025
@lkuligin
Copy link
Collaborator

lkuligin commented Feb 4, 2025

Noted!
Feel free to add a comment to the corresponding line at pyproject.toml if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artdent @lkuligin