Skip to content

Commit 62e648a

Browse files
hinthornweyurtsev
andauthored
Support correction when creating feedback with token (#736)
Closes #735 --------- Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
1 parent a74e072 commit 62e648a

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

langserve/api_handler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1590,6 +1590,7 @@ async def create_feedback_from_token(
15901590
score=create_request.score,
15911591
value=create_request.value,
15921592
comment=create_request.comment,
1593+
correction=create_request.correction,
15931594
metadata=metadata,
15941595
)
15951596

tests/unit_tests/test_server_client.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3066,7 +3066,8 @@ async def test_token_feedback_endpoint() -> None:
30663066
local_app, raise_app_exceptions=True
30673067
) as async_client:
30683068
response = await async_client.post(
3069-
"/token_feedback", json={"token_or_url": "some_url", "score": 3}
3069+
"/token_feedback",
3070+
json={"token_or_url": "some_url", "score": 3},
30703071
)
30713072
assert response.status_code == 200
30723073

@@ -3077,4 +3078,5 @@ async def test_token_feedback_endpoint() -> None:
30773078
"metadata": {"from_langserve": True},
30783079
"score": 3,
30793080
"value": None,
3081+
"correction": None,
30803082
}

0 commit comments

Comments
 (0)