Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mixedbread as a new model provider #8523

Merged
merged 2 commits into from
Sep 24, 2024
Merged

feat: add mixedbread as a new model provider #8523

merged 2 commits into from
Sep 24, 2024

Conversation

hwzhuhao
Copy link
Contributor

@hwzhuhao hwzhuhao commented Sep 18, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

image
image
image
image
image
image

close #8522

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime labels Sep 18, 2024
@hwzhuhao hwzhuhao force-pushed the feat/mixedbread branch 2 times, most recently from 077dd3e to 99b97a5 Compare September 19, 2024 04:27
@crazywoola
Copy link
Member

Please add the tests accordingly.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 23, 2024
@hwzhuhao
Copy link
Contributor Author

@crazywoola I have added the tests, pls help me to review again, thanks.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2024
@crazywoola crazywoola merged commit 1ecf70d into langgenius:main Sep 24, 2024
6 checks passed
hgnulb pushed a commit to hgnulb/dify that referenced this pull request Sep 26, 2024
@hwzhuhao
feat: add mixedbread as a new model provider (langgenius#8523)
2f54e44
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
@hwzhuhao @cuiks
feat: add mixedbread as a new model provider (langgenius#8523)
aeb3a1d
@hwzhuhao hwzhuhao deleted the feat/mixedbread branch October 6, 2024 00:35
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@hwzhuhao @lau-td
feat: add mixedbread as a new model provider (langgenius#8523)
fd6d579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add mixedbread as a new model provider
2 participants
@hwzhuhao @crazywoola